search

Mezryss / FVTT-Genesys

Foundry VTT: Unoffocial implementation of the Genesys RPG
MIT License
26 stars 11 forks source link

Bugfix: Allows upgrading ranked talents that are at tier 5. #41

Closed Assembling-Kings closed 1 year ago

Assembling-Kings commented 1 year ago

Tested it by creating a bunch of character sheets and trying the different use cases mentioned on #40

Assembling-Kings commented 1 year ago

I'm aware that you might not like the logic to remain were it's at (because of #14) but I didn't want to interfere with any plans you have for that.

Mezryss commented 1 year ago

I don't mean to just throw away your work so I'm sorry about this, but I'm going to be rewriting the talents logic completely as part of #14 - both the Inventory and Special Abilities/Talents tab and logic related to them are going to be getting rewritten entirely. This is the work I'm currently focused on, so it won't be long before I get the changes in-place (I'm expecting to get it ready to release in the next week or two, since my art term has ended and I have a couple weeks before my next one starts).

Also I think going forward, please don't include version bumps as part of pull requests - it'll help keep PRs cleaner and more focused specifically on the changes they're introducing, and it'll be easier to consolidate multiple changes into a single version bump.

I'll keep the PR open for now just in case I end up taking longer than I'm currently expecting to get the character sheet rewrite worked out.

Assembling-Kings commented 1 year ago

Sounds good, sorry for the inconvenience. Wrt the version bump, that's fair. I was just following the format you used when you fixed a bug.

Mezryss commented 1 year ago

No worries! I think even for my changes, I'm planning to adjust the process I use for when and where I include the version bump in commits.

Mezryss commented 1 year ago

Taking this in for now, since I'm not sure when I'll have the energy to get around to resuming the cleanup.