search

Mezryss / FVTT-Genesys

Foundry VTT: Unoffocial implementation of the Genesys RPG
MIT License
26 stars 9 forks source link

Journal entries for skill upgrades are showing the wrong rank #42

Closed Assembling-Kings closed 1 year ago

Assembling-Kings commented 1 year ago

When upgrading a skill the journal logs the new rank as one higher than usual. The problem is in [this line of code] (notice that a few lines above it the rank was already increased so adding the +1 is unnecessary.

Starting Sheet: image

After buying 5 ranks in Athletics: image

Journal: image

Assembling-Kings commented 1 year ago

The fix is easy as I mentioned above but I didn't make a pull request because I'm not sure if (or how) you want to do a migration to change all sheets already created.

Mezryss commented 1 year ago

Not sure where along the lines this broke, but as I mentioned in #40 the XP Journal is going to be getting an overhaul as part of the character sheet rewrite (#14) that I'm currently working on, so this should get resolved as part of that.