search

Mezryss / FVTT-Genesys

Foundry VTT: Unoffocial implementation of the Genesys RPG
MIT License
26 stars 11 forks source link

Ranked Talent effects don't stack per rank #44

Closed thirionlogan closed 1 year ago

thirionlogan commented 1 year ago

Ranked Talent effects don't stack per rank, for Example: If I create the talent "Toughened" and add a passive effect that adds 2 to the wound threshold of a character, it will do so just fine for the first rank but won't do so for additional ranks.

image

This should be 14: image

JackDCondon commented 1 year ago

Im pretty sure this is working as intended? As not every ranked talent will double its outputs? I would just edit it to plus 4 when you rank it up. Its a good idea to teach your players this stuff, its as critical as doodling reminders on your pen and paper sheet imo.

JackDCondon commented 1 year ago

Actually it would be great to be able to add an inline attribute for the item to use 2* {system.rank} so it would scale! Not sure if this is supported but its worth a go.

Mezryss commented 1 year ago

Im pretty sure this is working as intended? As not every ranked talent will double its outputs? I would just edit it to plus 4 when you rank it up. Its a good idea to teach your players this stuff, its as critical as doodling reminders on your pen and paper sheet imo.

No, the intent is that they should be applied per-rank. See GenesysEffect#apply().

thirionlogan commented 1 year ago

Wow! Thanks for fixing this so quickly! As an aside, do you have any features or issues you aren't working on that I could pick up? I'd like to contribute to give back to a wonderful project, and I'm also planning on GMing a campaign soon 😁