Mfarooq360 / WinThumbsPreloader

WinThumbsPreloader is a simple open source tool for preloading thumbnails in Windows Explorer.
MIT License
66 stars 1 forks source link

Inconsistent skipped images when generating thumbnails with 1.1.0 #2

Open VL4DST3R opened 1 year ago

VL4DST3R commented 1 year ago

I've encountered an odd behavior with 1.1.0 where some thumbnails seem to not be generated at all, effectively ending up with some sub-folders with no thumbnails generated whatsoever. I'm not yet sure if it is due to the fact i ran it with -r or -m (or both) but figured i should point it out.

(Also since at this point it's been mostly us here, I might as well use this as a sort of forum thread as well: i was wondering if there are any updates on the features you last mentioned working on, on the other issue i made?)

Mfarooq360 commented 1 year ago

Hello again, I know it's been a while, but I've been surprisingly busy recently. The next version of the project is looking great so far, but I've been unable to have enough free time to test it thoroughly enough.

I may put out a beta on a separate repository and hopefully be able to add all the features that were requested and fix as many bugs as I can find before putting out the proper release.

The separate repository should help to make it more discoverable on Google and helps with distinguishing between the programs due to the large amount of changes that were made to the program.

I would like to know more about this issue since I haven't encountered this problem yet, but my guess would be that the program isn't running as administrator which may force it to skip some folders.

I added a toggle to the new version of the program that would be able to help run the program as admin in both the command line and the explorer context menu, but in the current version, you may be able to set running as admin as a compatibility flag on the exe to allow it to scan more files and folders.

Mfarooq360 commented 1 year ago

In the meantime, here's a preview of what I've done so far for the next version (Work in Progress):

https://github.com/Mfarooq360/WinThumbsPreloader/assets/97059075/55122d9c-b464-4280-b735-39929b209f27

VL4DST3R commented 1 year ago

I would like to know more about this issue since I haven't encountered this problem yet, but my guess would be that the program isn't running as administrator which may force it to skip some folders.

Since keeping the thumbnails in place at all has been an issue for me, i wasn't really keen on nuking them and rebuilding them just to test it out, instead i just noticed it whenever i DID need to update them. I also had it where the main folder would generate thumbs fine, but any subfolder thumbnails (and its contents) would not even though i was running with -r.

I was low-key hoping this was something you caught already yourself and would be aware of it as well, but alas. Next time it happens ill be sure to document the issue better.

Not sure if it is worth mentioning or not, but my current setup to update my thumbs system-wide is via a set of bat scripts, one for each drive, to achieve a sort of pseudo-parallelism without overloading the whole thing (like i initially did in the other thread where i would spawn processes for each folder i had to generate).

The bat script commands are in the form of "E:\Programs\WinThumbsPreloader\WinThumbsPreloader1.1.0.exe" -r -m "G:\Screenshots" - for posterity

I added a toggle to the new version of the program that would be able to help run the program as admin in both the command line and the explorer context menu, but in the current version, you may be able to set running as admin as a compatibility flag on the exe to allow it to scan more files and folders.

Permissions shouldn't be an issue, given that i had the same folders in the same configuration throughout the years and previous WinThumbs versions and they generated just fine.

In the meantime, here's a preview of what I've done so far for the next version (Work in Progress):

Looks great! Love the backup/restore function! Have you also considered having the internal list of folders to generate so one can stop relying on scripts for handling multiple different folders?

Mfarooq360 commented 1 year ago

Hi, I've been trying to see how this issue is caused, but it seems to be working fine based on those commands used.

I've just released the beta for the new version here, which should include better command line argument parsing, if it would help any: https://github.com/Mfarooq360/WinThumbsPreloader-V2/releases

Have you also considered having the internal list of folders to generate so one can stop relying on scripts for handling multiple different folders?

I'm experimenting with how to implement processing multiple folders at once, it may be similar to how adjusting the thread count works in the program where it could be set in the settings or in the command prompt. I may also add an additional option to the context menu that prompts the user to select how many folders should be processed at once. With the help of the command line being able to take multiple paths, it should make it easier to implement.

I'm hoping that the issue gets resolved with the new version, as I have been unable to reproduce it. If it doesn't improve I may try to implement logging to see if I could find out what's causing the problem from there.

carlosvsilva commented 10 months ago

why not replace windows internal .heic thumb generator for on the fly generation?