MgAl2O4 / FFTriadBuddy

FF14 Triple Triad helper
MIT License
129 stars 17 forks source link

Some missing translations in the "Adjust detection" interfaces #38

Closed ShadyWhite closed 3 years ago

ShadyWhite commented 3 years ago

As shown in the pictures: QQ截图20210607130835 QQ截图20210607125652

And, I found that some icons do not correspond to the card name. For example, in this picture, the icon is "Shadowbringers Y'shtola", but the name is displayed as "Shadowbringers Urianger". QQ截图20210607133101

By the way, would you be interested in adding an "About" tab to the Tools home page? You can list Credits lists, links to your Patreon, links to the tool's repo, links to Crowdin translations, etc.

MgAl2O4 commented 3 years ago

Thanks for report, I'll add missing localization keys.

Y'shtola: this is worrying. Entry comes directly from loc.xml = datamined strings

  <loc type="3" id="267" de="Innozenz" en="Innocence" fr="Innocence" ja="イノセンス" cn="雅·修特拉(暗影)" ko="이노센스" />
  <loc type="3" id="268" de="Y'shtola (Shadowbringers)" en="Shadowbringers Y'shtola" fr="Y'shtola (Shadowbringers)" ja="ヤ・シュトラ(漆黒)" cn="于里昂热(暗影)" ko="야슈톨라(칠흑)" />
  <loc type="3" id="269" de="Urianger (Shadowbringers)" en="Shadowbringers Urianger" fr="Urianger (Shadowbringers)" ja="ウリエンジェ(漆黒)" cn="兰吉特" ko="위리앙제(칠흑)" />

Judging by position of ( ) in different languages, it looks like card id numbers are offset in CN source? Will investigate.

About page: actually, this is a good idea, at least for exposing translation and bug report links. Credits/contributors exist in github/crowdin projects and keeping them in sync with tool (especially translation) will be a pain.

ShadyWhite commented 3 years ago

Y'shtola: this is worrying. Entry comes directly from loc.xml = datamined strings

  <loc type="3" id="267" de="Innozenz" en="Innocence" fr="Innocence" ja="イノセンス" cn="雅·修特拉(暗影)" ko="이노센스" />
  <loc type="3" id="268" de="Y'shtola (Shadowbringers)" en="Shadowbringers Y'shtola" fr="Y'shtola (Shadowbringers)" ja="ヤ・シュトラ(漆黒)" cn="于里昂热(暗影)" ko="야슈톨라(칠흑)" />
  <loc type="3" id="269" de="Urianger (Shadowbringers)" en="Shadowbringers Urianger" fr="Urianger (Shadowbringers)" ja="ウリエンジェ(漆黒)" cn="兰吉特" ko="위리앙제(칠흑)" />

Judging by position of ( ) in different languages, it looks like card id numbers are offset in CN source? Will investigate.

My guess is that because of the version difference, a new card was inserted into the middle of the list, causing the numbering of the cards behind it to change.

MgAl2O4 commented 3 years ago

Fixed in v66, will add about page on next UI rework (waiting until someone wants and makes FR translations, which are most likely to break layout)