search

MgAl2O4 / FFTriadBuddyDalamud

Dalamud plugin for TriadBuddy
MIT License
35 stars 20 forks source link

FailedToParseNpc when playing NPCs with spaces in name (German localisation) #5

Closed tschoerk closed 3 years ago

tschoerk commented 3 years ago

When playing a game in the German localisation vs. an NPC which has a space in their name, for example Stolzer Hirsch der Neureiche (Prideful Stag) or Flichoirel der Höchnäsige (Flichoirel the Lordling) the status says FailedToParseNpc.

In the prepartion screen itself, the NPC is succesfully recognized: Status: Minigame not active Prep.NPC: Stolzer Hirsch der Neureiche Prep.Rules: Plus

Also the deck selection shows the approximate win percentages.

Only after selecting a deck and the game starts it switches to: Status: FailedtoParseNPC Solver.NPC: -- Solver.Move: --

This only seems to happen with NPCs which have space in their name, since all others works just fine. Didn't test if this is a localisation problem or arises with every language version.

MgAl2O4 commented 3 years ago

Hm, checked on tutorial NPCs with German client (Jonas Pik, etc), but it seems to work fine. Maybe those two from battle hall are more special, will see.

tschoerk commented 3 years ago

You're right the space isn't the problem apparantly. NPCs like Sezul Totoloq work as well. Outside the battle hall it only seems to also happen with (can only test ARR npcs, haven't played further) Arbeitsfauler Garlear (Indolent Imperial)

MgAl2O4 commented 3 years ago

Ah, I see. I'm reading game data wrong, particular npc name ends up being "Flichoirel [t] Hochnäsig[a]". You're using api3 build (live Dalamud release), right?

tschoerk commented 3 years ago

Yes I'm using the stable, live api3 version (Dalamud vD5.2.7.0).

MgAl2O4 commented 3 years ago

Should be fixed in 1.0.2.1 Npc name will show those [t], [a] grammar markups in status window, but it's just minor inconvenience - game logic will use correct npc card pools.