Add array sorting - Githubissues

MhdSyrwan / aor-embedded-array

Embedded Arrays for Admin On Rest

MIT License

39 stars 10 forks source link

Add array sorting #32

Open langhard opened 6 years ago

langhard commented 6 years ago

It's not drag and drop (Issue #6), but a possibility to sort the arrays.

MhdSyrwan commented 6 years ago

Great, I will check this in the evening. BTW, I think calling this feature sorting would be misleading. It should be called re-ordering, ordering .. etc.

Do you have any name suggestions ?

langhard commented 6 years ago

Cool, thx! I like „sorting“ but (re-)ordering is also ok.

langhard commented 6 years ago

Could you already have a look at the PR?

MhdSyrwan commented 6 years ago

I had a closer look at the code, but unfortunately haven't had the chance to run it.

Let's create a task list:

[ ] Rename feature name related variables, prop names and documentation.
[ ] Add some test cases to the test suite regarding this feature.
[ ] Make sure that the method you used Array.prototype.move exists in any current/future standard.

langhard commented 6 years ago

Updated task list:

[X] Rename feature name related variables, prop names and documentation.
[ ] Add some test cases to the test suite regarding this feature.
[ ] Make sure that the method you used Array.prototype.move exists in any current/future standard.

Question: What do you mean with "Make sure that the method you used Array.prototype.move exists in any current/future standard." Can you help me with that?

MhdSyrwan commented 6 years ago

@langhard I've researched more about the move method. I was mistakenly thinking that it's an obsolete method of the JavaScript array prototype. And forgot about the fact that items is a FieldArray and not a normal JS array.

Currently our new todo list is:

[x] Rename feature name related variables, prop names and documentation.
[ ] Add some test cases to the test suite regarding this feature.

Sorry for the inconvenience.