Mhopkinsinc / NHL94SNESVault

ROM Hacks for NHL '94 on the SNES

The Unlicense

3 stars 0 forks source link

Code Refactor - Def. Control Remove Hijack when not Enabled #17

Closed Mhopkinsinc closed 7 months ago

Mhopkinsinc commented 7 months ago

User story

Similar to #12 , Remove the code hijack and restore the original code when the hack isn't enabled.

Expected Result

Compiled rom is 1:1 in the offset that is used for the hijack as it is restored to the original

Benefits

[x] This keeps code running 1:1 to the original rom, when a hack isn't enabled.

Actual Changes

Modify the DefControl.asm patch with an else that restores to the original when not enabled.

Acceptance criteria

[x] Compiled Rom - Is 1:1 in the offset that was used as the hijack point for the patch when disabled.
[x] Hex compare confirms.
[x] Provided brief description of the actual changes (Solution) performed.

Sprint Ready Checklist

[x] Acceptance criteria defined.
[x] Identified solution / steps to satisfy acceptance criteria.
[x] Acceptance criteria is verifiable / testable.

Mhopkinsinc commented 7 months ago

working according to acceptance criteria