Mhopkinsinc / NHL94SNESVault

ROM Hacks for NHL '94 on the SNES

The Unlicense

3 stars 0 forks source link

Hack Request - Pull CPU Goalie Earlier when Losing #21

Closed Mhopkinsinc closed 7 months ago

Mhopkinsinc commented 7 months ago

User story

Add the functionality for the CPU to pull the goalie earlier in the 3rd period. Also if losing by more than 2 goals.

Possible Solution

[x] Trace when the CPU goalie is pulled in the 3rd period and losing by 1 or 2 goals
[x] Review the code that is run when this happens and see what ram values are used and can be modified.
[x] Make this configurable in the Config.asm file
[x] Mesen Trace File

Actual Solution

Added 2 entries to the config.asm file to modify time remaining when cpu pulls goalie and how many goals they are losing by.
Added CPUPullGoalie.asm patch file to patch the rom based on the config values.
Documented the function in depth, added rom / ram values found to the diz file and the excel file
Marked a lot of new code in diz from bsnes live trace logging

Acceptance criteria

[x] Game Play - CPU Goalie is pulled at the time configured in the config.asm file when losing by 1-x goals.
[x] Updated SNES NHL94 ROM-RAM Mapping Project with any new values.
[x] DiztinGUIsh DizRaw file is up to date and has any necessary comments with changes.
[x] Provided brief description of the actual changes (Solution) performed.

Sprint Ready Checklist

[x] Acceptance criteria defined.
[x] Identified solution / steps to satisfy acceptance criteria.
[x] Acceptance criteria is verifiable / testable.

Mhopkinsinc commented 7 months ago

Closing Issue, This corrects code from #12

Mhopkinsinc commented 7 months ago

Debug Screen Shots Goalie getting pulled with 1 minute left GoalieGettingPulled1minLeftByCPU

Goalie getting pulled when there is a penalty PenaltyCalledGoalieBeingPulled

Goalie being put back in after the penalty GoaliePutBackInAfterPenalty