Mhopkinsinc / NHL94SNESVault

ROM Hacks for NHL '94 on the SNES

The Unlicense

3 stars 0 forks source link

Hack Request - Enable Hidden 30 Second Periods #3

Closed Mhopkinsinc closed 7 months ago

Mhopkinsinc commented 7 months ago

User story

Enable the hidden "30 Seconds" period menu option.

Possible Solution

[x] Identify the code that controls the # of items to display in the period selection of game setup
[x] Modify code so it shows the hidden "30 second" option

Actual Solution

There are ROM offsets that control the number of options to display in the list for every Game Setup option.
Identified the ROM offset [EACD7] that controls Period Length and changed the value from 3 to 4. This allowed the 30 second period option to display.
Made the option configurable in the Config.ASM file
For Gens modify 0xF7927 from 03 to 04 Verified and tested.

Acceptance criteria

[x] Game Setup Screen - When selecting Period Length, 30 seconds should show as an option.
[x] Game Play - 30 second periods are working in game play.
[x] Updated SNES NHL94 ROM-RAM Mapping Project with any new values.
[x] DiztinGUIsh DizRaw file is up to date and has any necessary comments with changes.
[x] Provided brief description of the actual changes (Solution) performed.

Sprint Ready Checklist

[x] Acceptance criteria defined.
[x] Identified solution / steps to satisfy acceptance criteria.
[x] Acceptance criteria is verifiable / testable.

Mhopkinsinc commented 7 months ago