search

Mi-V-Soft-RISC-V / miv-rv32-bare-metal-examples

5 stars 2 forks source link

JumpToApplication has two arguments that are not used #1

Closed DragonSpit closed 1 year ago

DragonSpit commented 2 years ago

Could these be either removed or explained, since the return address is hardcoded inside the function.

nitindeshpande commented 2 years ago

@DragonSpit Thanks for pointing this. Assuming Bootloader_JumpToApplication

@param stack_location The application stack address. Bootloader will provide this address to the application, so the application can start using it immediately when it starts. @param reset_vector The execution start address for the application.

The Application is currently design to be used with the DGC design where this function is not used. We intend to use the parameters instead of the hardcoded value in the next version.

nitindeshpande commented 1 year ago

Fixed with 2022.12. Unused code is removed.