MiCode / FileExplorer

MIUI文件管理器社区开源版(Community edition of MIUI File Explorer)
http://micode.net/forum-51-1.html
1.6k stars 763 forks source link

Add support for landscape orientation #16

Closed karora closed 11 years ago

karora commented 11 years ago

Hi,

I use FileExplorer on several tablets and it works well, but found it frustrating that it only worked in portrait mode, especially on my Asus Transformer when I had the keyboard connected...

This patch enables landscape (sensor) orientation, adjusting the CategoryBar to operate vertically in this case.

Thanks for your hard work :-)

Regards, Andrew McMillan.

haonan commented 11 years ago

Karora, thanks for your commit. But, i find a little problem:if enter one of the categories, such as music category, then i change the orientation, the app back to homepage.

karora commented 11 years ago

On Mon, 2012-09-17 at 00:03 -0700, 戚冬杰 wrote:

Karora, thanks for your commit. But, i find a little problem:if enter one of the categories, such as music category, then i change the orientation, the app back to homepage.

Hi,

Maintaining state across orientation change is a different class of problem than the one I solved here.

I've met my immediate need with my fork now, and thought others might also want to see it. Unfortunately I will not have time to make any changes to store the state in the onPause and re-load it in the onResume, but perhaps someone with a more detailed knowledge of the app's internals would be better able to do that in any case.

I hope you accept this patch, in any case, and it doesn't suffer as a victim of "perfect is the enemy of good", but rather follows in the "release early, release often" tradition of open source.

Regards, Andrew McMillan.


http://andrew.mcmillan.net.nz/ Porirua, New Zealand Twitter: _karora Phone: +64(272)DEBIAN

History books which contain no lies are extremely dull.

haonan commented 11 years ago

Thanks for your patch. :)