search

MiCode / FileExplorer

MIUI文件管理器社区开源版（Community edition of MIUI File Explorer)
http://micode.net/forum-51-1.html
1.6k stars 763 forks source link

Potential issue for an integer overflow #39

Open waooog opened 6 years ago

waooog commented 6 years ago

Hi,

Our tool found the following suspicious code in: src/org/swiftp/CmdLIST.java

In Line 38: public final static long MS_IN_SIX_MONTHS = 6 * 30 * 24 * 60 * 60 * 1000;

Could this be as follow to avoid integer overflow?:

public final static long MS_IN_SIX_MONTHS = 6 * 30 * 24 * 60 * 60 * 1000L;

This might be a trivial thing but I wanted to report just in case.

Thanks!