search

MiKatt / openSTARS

open source implementation of the STARS ArcGIS toolbox
https://journals.plos.org/plosone/article?id=10.1371/journal.pone.0239237
Other
46 stars 13 forks source link

Changed scope of if statment regarding predictor_r_names #13

Closed HunterGleason closed 3 years ago

HunterGleason commented 4 years ago

The openSTARS::import_data() function seemed to be ignoring predictor_r_names when provided do to scope issue with if statement.

HunterGleason commented 4 years ago

Thanks to you all for writing such a great package, very simple fix, must have been a typo.

From: MiKatt notifications@github.com Sent: June 2, 2020 12:06 AM To: MiKatt/openSTARS openSTARS@noreply.github.com Cc: Gleason, Hunter FLNR:EX Hunter.Gleason@gov.bc.ca; Author author@noreply.github.com Subject: Re: [MiKatt/openSTARS] Changed scope of if statment regarding predictor_r_names (#13)

@MiKatt approved this pull request.

Thanks for spotting this!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MiKatt/openSTARS/pull/13#pullrequestreview-422396146, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKCKPC3HRLMIUCZF4WHXZUTRUSQGTANCNFSM4NQFYI7A.

MiKatt commented 3 years ago

Changed in dev branch.