search

MiKatt / openSTARS

open source implementation of the STARS ArcGIS toolbox
https://journals.plos.org/plosone/article?id=10.1371/journal.pone.0239237
Other
46 stars 13 forks source link

Extended processing times: calc_attributes_sites_approx #14

Closed HunterGleason closed 3 years ago

HunterGleason commented 3 years ago

Since the most recent update of the openSTARS package (1.2.0) I have found that when running the calc_attributes_sites_approx() command on both observed and particularity predicted site data, processing times are orders of magnitude longer than in the previous package version (same script). I am curious what changes may have led to the longer processing times in the updated openSTARS package?

MiKatt commented 3 years ago

Thanks for this comment. I will look into it soon as I am preparing so other updates and will come back to you.

MiKatt commented 3 years ago

I compared the two releases (https://github.com/MiKatt/openSTARS/compare/v1.1.0...v1.2.0#diff-a2f3d86e1cc1c18e1c9db713cddb1523) and cannot find anything that might cause this increase in processing time; it should even be a bit faster as it uses now a less complex query. Did you change anything else on your system (R or Grass version)?

HunterGleason commented 3 years ago

Thanks for looking into this. It could be an issue on my end as I think I am running a different version of R (now running 3.6.3). I believe I am using the same GRASS version however (7.6.0). It does finish in a very reasonable time (about an hour for Bowron watershed, BC), so not really an issue. Just seemed like it was taking longer than before the update.

Also I was getting an error when I set calc_basin_area to FALSE, it went something like “in cnames2 %in% cnames can’t find cnames”, but don’t get this error when calc_basin_area is set to TRUE?

Thanks, Hunter

From: MiKatt notifications@github.com Sent: July 15, 2020 7:40 AM To: MiKatt/openSTARS openSTARS@noreply.github.com Cc: Gleason, Hunter FLNR:EX Hunter.Gleason@gov.bc.ca; Author author@noreply.github.com Subject: Re: [MiKatt/openSTARS] Extended processing times: calc_attributes_sites_approx (#14)

CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe.

I compared the two releases (v1.1.0...v1.2.0diff-a2f3d86e1cc1c18e1c9db713cddb1523https://github.com/MiKatt/openSTARS/compare/v1.1.0...v1.2.0diff-a2f3d86e1cc1c18e1c9db713cddb1523) and cannot find anything that might cause this increase in processing time; it should even be a bit faster as it uses now a less complex query. Did you change anything else on your system (R or Grass version)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/MiKatt/openSTARS/issues/14#issuecomment-658809040, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKCKPC7DWHTE4VNQ5Q55OY3R3W5VXANCNFSM4OUYFRUQ.