Doesn't switch appearance for Dark Mode (10.14)

MiMo42 / MMTabBarView

A Mac OS X tab bar view that works on 10.9+ with Xcode 9.3+. Pull requests welcomed.

http://mimo42.github.com/MMTabBarView/

243 stars 79 forks source link

Doesn't switch appearance for Dark Mode (10.14) #61

Closed balthisar closed 3 years ago

balthisar commented 6 years ago

In Mojava preview (10.14), tabs don't change appearance when Dark Mode is active, although the font does change.

I'll take a stab at it in the near future if no one else steps up.

balthisar commented 6 years ago

Addressed in #62. Note that the PR updates the deployment target to 10.10, which is I think is finally due.

In addition to dark mode support as reported in the issue, I think this is the first tab style to also support high contrast mode, as well as provide proper dimming appearance when the window is not active.

Enjoy!

estella144 commented 3 years ago

@balthisar 10.14 has been superseded.

RobFog commented 3 years ago

@balthisar 10.14 has been superseded.

What do you mean by that? 10.15 also has Dark Mode.

balthisar commented 3 years ago

This issue refers to a PR that was merged several years ago. I'm not really sure what the penultimate comment is referring to, but given the merged PR, I think I'll close this.