MiMo42 / MMTabBarView

A Mac OS X tab bar view that works on 10.9+ with Xcode 9.3+. Pull requests welcomed.
http://mimo42.github.com/MMTabBarView/
243 stars 79 forks source link

Introduce Mojave style tabs: #62

Closed balthisar closed 6 years ago

balthisar commented 6 years ago

About:

This is probably the best tab style there is for MMTabBarView, in terms of functionality and adherence to Apple's user interface.

TAKeanice commented 5 years ago

I have not seen a reason to drop 10.9 support in your commit @balthisar . Can you elaborate which modern, incompatible APIs you used? Reverting in XCode to 10.9 threw no compiler errors ("only available starting 10.10" or the like). Additionally, there were some strange @available(macOS 10.11) checks, where the if branch and the else branch were the same. I was able to remove all of them and still compile just fine. Take a look at the version in the Vienna repository for reference: https://github.com/ViennaRSS/MMTabBarView/pull/7

TAKeanice commented 5 years ago

I figured out why there were the @available checks, but the reasons for the incompatibility with 10.9 would still be of interest to me. Meanwhile, in Vienna, we tested our version on 10.9, and it works flawlessly.

barijaona commented 5 years ago

Sorry, @TAKeanice, I caused confusion, due to problems with my builds.

I correct : Mojave style does not work in 10.9. In MMMojaveTabStyle+Assets.m, there are two instances of uses of [NSColor labelColor] which can only be used in 10.10 or later.

TAKeanice commented 5 years ago

Alright, that means the color is incorrect? We can circumvent this with @available checks at the two instances, can´t we?

barijaona commented 5 years ago

It means the app throws an exception. Yes, this could probably be circumvented with @available checks, but I haven't tried it yet.