MiMo42 / MMTabBarView

A Mac OS X tab bar view that works on 10.9+ with Xcode 9.3+. Pull requests welcomed.
http://mimo42.github.com/MMTabBarView/
243 stars 79 forks source link

viewDidEndLiveResize in MMTabBarView causes window to freeze on Mojave when entering full screen window mode. #63

Open brendand opened 6 years ago

brendand commented 6 years ago

It seems to have something to do with viewDidEndLiveResize:

    for (MMAttachedTabBarButton *aButton in [self attachedButtons]) {
        [[aButton indicator] startAnimation:self];
    }

    [self _checkWindowFrame];
    [self update:NO];
}

If you comment out [[aButton indicator] startAnimation:self]; then it no longer freezes.

brendand commented 6 years ago

If the window is frozen, clicking outside the app allows it to complete the transition to full screen mode. So even just clicking on an icon in the Dock allows it to continue.

barijaona commented 5 years ago

I confirm the problem, and that removing the animations in -viewDidEndLiveResize: work around it.

hankinsoft commented 4 years ago

I switched:

[[aButton indicator] startAnimation:self];

to

[[aButton indicator] performSelector:@selector(startAnimation:) withObject:nil afterDelay:0.0];

And that sorted the issue as well.