search

MiMo42 / MMTabBarView

A Mac OS X tab bar view that works on 10.9+ with Xcode 9.3+. Pull requests welcomed.
http://mimo42.github.com/MMTabBarView/
243 stars 79 forks source link

Mojave tab labels are blurry in dark mode #68

Open ychin opened 5 years ago

ychin commented 5 years ago

Mojave-style tabs currently have a blurry drop shadow under the label text that's very visible in Dark Mode, which looks messy. Native tabs do not have that and therefore look a lot cleaner.

From what I can tell the culprit is at the following location:

https://github.com/MiMo42/MMTabBarView/blob/172a9d48aabcd029229f414ac6e182650884574f/MMTabBarView/MMTabBarView/MMTabBarButtonCell.m#L1049

It applies a global drop shadow to all text labels. When I turn it off locally, the text looks normal and much closer to what native tabs look like. I looked at the other styles too and they still looked fine after I removed the drop shadow code so I think this code could probably be removed, but I'm not sure what the original reasoning behind the drop shadow is (did Apple's Aqua/Metal-style tabs have drop shadows?). I think the drop shadow should at least be turned off for Mojave or other more modern tab styles.

barijaona commented 5 years ago

Seems to be solved by #70

RobFog commented 5 years ago

@nivekkagicom Do you think it's the same issue?

nivekkagicom commented 5 years ago

I believe they are the same issue.