MiSTer-devel / Apple-II_MiSTer

Apple II+ for MiSTer
48 stars 18 forks source link

Revert "add floppy sound emulation (#28)" #30

Closed Newsdee closed 3 months ago

Newsdee commented 3 months ago

This reverts commit 975090898112c122d23b94c19881cdc4ac340b93.

Testing with users made me realize the feature does not work well with headphones, so I decided to remove it until a proper fix can be made.

vanfanel commented 3 months ago

Out of curiosity, by using headphones, did you notice the high-pitch constant tone I told you about?

Also, since this is toggle-able, maybe it could be kept off by default instead of removing it.

Newsdee commented 3 months ago

Yes, that is the reason I am reverrtng the last PR

By testing with headphones I realized the high pitch hum exists even in the code I had already merged.

Right now I don't have time to investigate it so I want to leave the official repo in a good state.