search

MiSTer-devel / Arcade-DonkeyKong_MiSTer

Arcade: Donkey Kong for MiSTer
21 stars 22 forks source link

Sound issues #15

Open shertz43 opened 4 years ago

shertz43 commented 4 years ago

Each time you clear a level the tune thats played is off / not correct.

famiclone6502 commented 4 years ago

I owned an original Donkey Kong arcade machine, and I've noticed that the pitch is different for sound. Jumping over a barrel, or collecting items in the second level, it just sounds weird. Additionally, the overall lack of bass in the biggest difference I've noticed.

The game play does feel fine, just not the sound.

rhester72 commented 4 years ago

The sound of the walk is off as well - there's actually some randomness to the actual sound. This was discovered/addressed in MAME a while back when that driver was moved from samples to discrete audio drivers.

80sArcadeKid commented 3 years ago

The sound is the only really remaining piece of the puzzle to make this core accurate. Hoping one day someone makes the effort to fix it.

jopdorp commented 2 years ago

I've imeplemented a new walk sound, and added filtering to the final output, it sounds a lot closer to the original now. The source code is merged, you can build it from the source code now, or grab the test release from the test-builds on discord

80sArcadeKid commented 2 years ago

Great news, can't wait to try out the fixes.

80sArcadeKid commented 2 years ago

The sound is not fixed. I've investigated this more with a MAME v FPGA comparison video. I own an original PCB and MAME is definitely similar in sound to the PCB whereas Mister is off in lots of places. https://youtu.be/PCD7DFL4Bek

I also think that maybe the rom version is off? Old versions of MAME had very red girders like the FPGA implementation. This is just a thought on why it may be so different.

80sArcadeKid commented 2 years ago

Ok so to be more accurate I;ve done a direct PCB capture v FPGA comparison video. Same/similar issue but certainly some aspects a little closer.. maybe? https://youtu.be/Ew6pSeNG07o

80sArcadeKid commented 2 years ago

One last comparision to round this off, this time PCB v MAME, even though the MAME sound is quite a bit duller, the general tone is near identical. We want this on FPGA but with a nice crisp sound (maybe it was my PC settings for sound in MAME). Thanks for watching y'all, hope this helps. https://youtu.be/TWlyx9lr114

80sArcadeKid commented 2 years ago

OK very last video I promose, a more granular example to hopefully make it easier to compare when fixing. https://youtu.be/fKtifT8Nexg

Seems to be two constant issues, the pitch of overall sound, and the jingles (digital not analog?) are very beepy and scratchy.

80sArcadeKid commented 2 years ago

There is also this assume known https://github.com/furrykef/dkdasm/blob/master/dkong-snd.asm