search

MiSTer-devel / Arcade-DonkeyKong_MiSTer

Arcade: Donkey Kong for MiSTer
20 stars 21 forks source link

Radar Scope has only half of the sound effects. #42

Open birdybro opened 2 years ago

birdybro commented 2 years ago

Radar Scope doesn't currently have the sound effects for explosions or laser fire.

pvanschendel commented 8 months ago

I have looked into this, and I think this is the situation:

The Donkey Kong core uses samples of the analog sound effects that are strored in the .mra file. As far as I can tell, there is no radarscope .mra file, or MAME ROM archive, that contains sampled sound for the Radar Scope effects.

One way to fix this, is to get these samples from somewhere, put them in the .mra file, and make a few small changes in the donkey_kong.rbf to support that: radarscope has more effect bits, and their duration/address will be different. This may not work because radarscope may sometimes have two bits controlling the effect, one to the start the effect, and one to shut it down.

My merge request https://github.com/MiSTer-devel/Arcade-DonkeyKong_MiSTer/pull/60 fixes it in a way: When you enable analog sound effects, shooting in Radar Scope with start the analog emulation of the donkey kong walk sound :-D

I realize that this is just a TODO, and not a fix, but I hope this could be useful for anyone who would like to fix this. I have not been as fast with this project as I wanted to. If we get forward with analog emulation more, w might also get around to do analog emulation of the Radar Scope effect, which will be able to properly start and end the effect.

For bonus points, someone could add the speech as well: I came across this web site: https://www.ostermayer.ch/sou.html. I hope he might help anyone trying to do either solution. The funny thing is that this guy practically lives on my doorstep (practically, not literally, mind).