search

MiSTer-devel / Arcade-DonkeyKong_MiSTer

Arcade: Donkey Kong for MiSTer
20 stars 21 forks source link

New walk sound and other sound improvements #43

Closed jopdorp closed 2 years ago

jopdorp commented 2 years ago

I've added an analog simulation for the walk sound base on the MiSTer Discrete project I've been working on.

Also I've added filtering on the audio output and improved the volume mix to be closer to the original hardware.

lagomorph commented 2 years ago

While I applaud this approach to the walking sounds they currently don't sound even as accurate as the samples. I hope this is still a work in progress.

jopdorp commented 2 years ago

While I applaud this approach to the walking sounds they currently don't sound even as accurate as the samples. I hope this is still a work in progress.

it seems quite close to me, comparing to this for example: https://youtu.be/TXWWeTnIZM4?t=436

what do you think should be improved?

lagomorph commented 2 years ago

While I applaud this approach to the walking sounds they currently don't sound even as accurate as the samples. I hope this is still a work in progress.

it seems quite close to me, comparing to this for example:

https://youtu.be/TXWWeTnIZM4?t=436

what do you think should be improved?

To my ears it just sounds quite different. The pitch seems higher and "squeakier" than your example.

Turbochop commented 2 years ago

Try comparing it side by side with the samples that are still in the core, like the Jump sound for example. Your walk sound seems a little too high pitched.

jopdorp commented 2 years ago

Try comparing it side by side with the samples that are still in the core, like the Jump sound for example. Your walk sound seems a little too high pitched.

I will have a look, although I did measure and validate the frequency ranges. I'm wondering if it could be the filters being stronger on the original, or because of the YouTube video.

The MAME version seems to have stronger filtering, but I'm not entirely conviced it's accurate, what do you think?

Another thing that I could imagine is going on is that there might be a slight difference in the speed at which the sounds drop/rise in pitch?