MiSTer-devel / C64_MiSTer

111 stars 57 forks source link

Framework update broke disk swap detection ? #165

Open paich64 opened 5 months ago

paich64 commented 5 months ago

@sorgelig something went wrong in between 20240110 and 20240106 commits

With 20240106 commit, the following demo (https://csdb.dk/release/?id=48039) was still working fine (it's part of the bench of demos i have run) With 20240110 commit, swapping from disk 0 to disk 1 does not work anymore. Possibly other demos got impacted.

sorgelig commented 5 months ago

I have no problem with this demo on latest release. I'm using DolphinDOS. To swap disks i didn't remove old, just mounted new one.

paich64 commented 5 months ago

Yep but it was working without dolphindos and now it's not. Compatibility should remain garanteed without any alternative kernel which are more a bonus. Have you tried without dolphindos ?

paich64 commented 5 months ago

I have no problem with this demo on latest release. I'm using DolphinDOS. To swap disks i didn't remove old, just mounted new one.

The test i did was with standard kernel and removing / inserting the new disk.

paich64 commented 5 months ago

Basically all the demos I have tested were tested with standard kernel, and indeed i was surprised with this issue. Unless the framework influences in some way the mount/unmount phase ? I should have kept a backup of my SD card before updating the framework. I will re-test on my side, but definitely can't have this demo working with 20240110 commit.

eriks5 commented 5 months ago

Disk swap works for me as well, with stock kernal selected, for both disk swaps

sorgelig commented 5 months ago

You already mentioned before that unrelated change affected disk swap for you.. This is strange as it cannot be so sensitive. May be there is something affects it..

paich64 commented 5 months ago

damned... found the root cause but just can't figure out why this was not impacting with previous commits :

"Enable Drive #8:" was set to "ALWAYS". Switching it back to "If Mounted" solved the issue. And this was neither impacting other demos having disk swap involved .... There must be something i do not get with "Always" value for "Enable Drive #8:".