Regression - Loading issue with Below The Root

[dspiteri]

Observed on C64_20240110.rbf when loading Below the Root (GB64 version) the game crashes with DolphinDos, loads OK with stock kernal and with speeder carts. Also noticed on Windham Classics Alice in Wonderland (GB64 version).

This issue isn't present on C64_20231208.rbf. I also observed crashing for the same game on the c128 core with JiffyDos enabled but can load if I force 1541. This also worked before the update.

[sorgelig]

@eriks5 i believe it's broken by CIA tweaks.

[eriks5]

@sorgelig I can reproduce the issue with C64_unstable_20240102_223f9c and the CIA changes were merged on Jan 6, so I don't think it's related.

C64_unstable_20240101_188e63 does not have the issue, so it appears to be due to the disk change changes that were committed on Jan 2.

[sorgelig]

Actually i don't see a problem with this game. After changing the disk, try to press the space bar after 2-3 seconds, not immediately

[sorgelig]

Alice in Wonderland also works fine if you press space bar not immediately. Some games/demos require longer disk swap process, so core has been tweaked for that. As a side effect, for games requiring disk swap confirmation, wait for couple seconds and then confirm.

May be i need to block the keyboard while disk is in swapping process...

[eriks5]

Blocking the keyboard might be an option, but some form of visual feedback might be better. Maybe the MiSTer UI should remain open during the disk change delay?

[sorgelig]

UI can't be controlled by core. Any visual feedback should be made by core itself, like overlay.

[sorgelig]

Try upcoming unstable build. LED is ON while disk swapping is in process, keyboard is ignored.

[sorgelig]

I wonder, on real C64 what will happen in these games when you remove disk and press SPACE without disk

[dspiteri]

Good spotting @sorgelig I am too quick on the space! Thanks for getting this core nailed it is perfect now.