search

MiSTer-devel / Distribution_MiSTer

This repository contains all the files that you'll want in your MiSTer
GNU General Public License v3.0
93 stars 20 forks source link

The all_filters filter doesn't seem to be working #29

Closed prurigro closed 2 years ago

prurigro commented 2 years ago

Hi, first I should say thank you for the continued hard work on this!

I wanted to remove other-cores while keeping everything else update_all normally pulls in, so I added the following to my downloader.ini:

[mister]
filter = all_filters !other_cores

I assumed all_filters would result in a starting point with all filters applied which I could then negate from, but running update_all.sh proceeded to delete absolutely everything.

There's currently no description for all_filters so I might be misunderstanding its use case, but it also didn't appear to pull anything in. Either way, it would be great to have the full set of files as a starting point to then negate individual filters from.

Thanks!

theypsilon commented 2 years ago

Hey @prurigro , there is actually some description for all_filters in the README of this repository:

image

The filter you wanted to use is all. I didn't document that one because is really not necessary to use. When you use a negated filter, and no other non-negated filters, there will always be an implicit all filter applied. Otherwise you could not negate from an empty set, as you correctly guessed.

As a fun fact, if you use !all, you will delete ALL files from the database. Not very useful though!

prurigro commented 2 years ago

You're right, I definitely missed that when parsing (probably should have done a search!). Assuming I didn't also skim past mention of the implicit all, it might be worth mentioning that in the readme?

Thanks for the info and again for all your hard work!