MiSTer-devel / Downloader_MiSTer

Tool for installing and updating MiSTer cores and other files
GNU General Public License v3.0
112 stars 15 forks source link

downloader failed: "Could not load storage" #11

Closed eebaser closed 2 years ago

eebaser commented 2 years ago

Hello,

I am attempting to run update_all.sh script with the downloader enabled. The latest jtbeta.zip file is in my 'mame' folder and all of the necessary options are enabled, as far as I can tell, in the update_all options menu (i.e. Install Premium Cores, Install Unofficial Cores etc.) I am recieving the following error:


Reading file: /media/fat/download.ini Reading 'distribution_mister' db section Reading 'jtcores' db section Reading 'theypsilon_unofficial_distribution" db section Could not load storage Could not load json from "https://raw.githubusercontent.com/MiSTer--devel/Distribution_MiSTer/main/db.json.zip" Could not load json from "https://raw.githubusercontent.com/jotego/jtpremium/main/jtbindb.json.zip" Could not load json from "https://raw.githubusercontent.com/theypsilon/Distribution_Unofficial_MiSTer/unofficialdb.json.zip"

There were some errors in the Updaters. Therefore, MiSTer hasn't been fully updated.

Check these logs from the Updaters that failed:


I receive the same error when running just the downloader.sh script. All official cores were downloaded and installed correctly using update_all.

Thank you!

XAMPPRocky commented 2 years ago

I'm also running into this issue when trying to run the downloader.sh script. Log file:

START!

Reading file: /media/fat/downloader.ini
Reading 'distribution_mister' db section
Reading 'jtcores' db section
env: {
    "DOWNLOADER_LAUNCHER_PATH": "/media/fat/Scripts/downloader.sh",
    "DOWNLOADER_INI_PATH": null,
    "CURL_SSL": "--cacert /etc/ssl/certs/cacert.pem",
    "COMMIT": "75f429b",
    "ALLOW_REBOOT": null,
    "UPDATE_LINUX": "true",
    "DEFAULT_DB_URL": "https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip",
    "DEFAULT_DB_ID": "distribution_mister",
    "DEFAULT_BASE_PATH": null,
    "DEBUG": "false",
    "FAIL_ON_FILE_ERROR": "false"
}
config: {
    "databases": {
        "distribution_mister": {
            "db_url": "https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip",
            "section": "distribution_mister"
        },
        "jtcores": {
            "db_url": "https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip",
            "section": "jtcores"
        }
    },
    "base_path": "/media/fat/",
    "base_system_path": "/media/fat/",
    "allow_delete": 1,
    "allow_reboot": 1,
    "check_manually_deleted_files": true,
    "update_linux": true,
    "parallel_update": true,
    "downloader_size_mb_limit": 100,
    "downloader_process_limit": 300,
    "downloader_timeout": 300,
    "downloader_retries": 3,
    "zip_file_count_threshold": 60,
    "zip_accumulated_mb_threshold": 100,
    "filter": null,
    "url_safe_characters": {},
    "verbose": false,
    "config_path": "/media/fat/downloader.ini",
    "user_defined_options": [],
    "curl_ssl": "--cacert /etc/ssl/certs/cacert.pem"
}
subprocess.run unzip -p /media/fat//Scripts/.config/downloader/downloader.json.zip Return Code was '12'

error: invalid zip file with overlapped components (possible zip bomb)

Could not load storage
Loading db from url: https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip
Loading db from url: https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip
Downloading 2 files:
/tmp/temp_file12o9z9_f
/tmp/temp_filepp5_4p7x
*..

Checking hashes...
++
subprocess.run unzip -p /tmp/temp_file12o9z9_f Return Code was '12'

error: invalid zip file with overlapped components (possible zip bomb)

Could not load json from "https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip"
subprocess.run unzip -p /tmp/temp_filepp5_4p7x Return Code was '12'

error: invalid zip file with overlapped components (possible zip bomb)

Could not load json from "https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip"

===========================
Downloader 1.4 (75f429b) by theypsilon. Run time: 0:00:02.22s
Log: Scripts/.config/downloader/downloader.log

Installed:
none.

Errors:
https://raw.githubusercontent.com/MiSTer-devel/Distribution_MiSTer/main/db.json.zip, https://raw.githubusercontent.com/jotego/jtcores_mister/main/jtbindb.json.zip

Running update_linux
linux_descriptions_count: 0
Length of failed_dbs: 2
XAMPPRocky commented 2 years ago

The solution I found is to run the update.sh first. Once this has run, these scripts start to work.

theypsilon commented 2 years ago

This was coming from an old version of Linux, it should not happen with new ones.