search

MiSTer-devel / Filters_MiSTer

Custom Filters for MiSTer's HDMI Scaler
36 stars 12 forks source link

Scanlines bright with protected highlights. #19

Closed ash2hub closed 3 years ago

ash2hub commented 3 years ago

Modified version of Scanlines (Bright) with protected highlights. Used logistic function to level off upper end. Included script used. If the script is not wanted, I can take it out.

birdybro commented 3 years ago

Interesting to see powershell used for this! :D

ghogan42 commented 3 years ago

As per the forum I think we should fix two things: (1) Names. We don't need it so long like SL_BRPHY I'm not sure what to use though. Basically what you've done is as the brightness boost goes up, you are making the scanline thinner (well I haven't looked at the output yet but..._). And the higher the boost of the original filter (...,120, 125, 130...) the thinner the scanline becomes.

So we could do something like SL_PHY_130_XX

Or like this SL_Thin_130_XX

Or something else. I'm not sure what is best. What do you think is good?

(2) Right now the number for the scanline darkness is incorrect. Like on the 120% brightness 50% scanlines I think the dark part is 60% of full brightness. I don't know of a good way to fix that without regenerating my filters with different scanline darknesses designed so that after your script the results will be what we want. I'll just try to do that.

So probably I'll reject this pull request (not until we have the new one) and put up one with what I think are fixed versions.

ash2hub commented 3 years ago

Closing in favor of ghogan42's work. Thanks for taking the ideas into consideration!