search

MiSTer-devel / GBA_MiSTer

GBA for MiSTer
GNU General Public License v2.0
142 stars 44 forks source link

Added GPIO quirk to games that have rumble ROM hack #133

Closed djedditt closed 1 year ago

djedditt commented 1 year ago

These games officially support rumble through the Game Boy Player (GameCube peripheral). The rom hacks in question enable and translate the Game Boy Player rumble signals to cartridge rumble signals. This also allows them to be picked up by MiSTer, but only by default when gpio_quirk is set.

Mario & Luigi: Superstar Saga (Cartridge Rumble Patch) https://www.romhacking.net/hacks/6065/

Pokémon Pinball: Ruby & Sapphire (Cartridge Rumble Patch) https://www.romhacking.net/hacks/6256/

Super Mario Advance 4: Super Mario Bros. 3 (Cartridge Rumble Patch) https://www.romhacking.net/hacks/6234/

RobertPeip commented 1 year ago

Does the Game ID change when applying the patch? Usually that does not happen.

If not, are you sure the original, unpatched games still works with the GPIO hack on?

The GPIO hack will prevent the game to fetch data from some addresses of the Cart, so having it enabled on a unpatched game can lead to all kind of bugs.

djedditt commented 1 year ago

The patches do not alter the game IDs in the header.

I just learned that you can manually apply GPIO overrides through the OSD, so I would actually rather not add them by default anymore.