search

MiSTer-devel / GBA_MiSTer

GBA for MiSTer
GNU General Public License v2.0
142 stars 44 forks source link

Feature Request: CRT Vertical/Horizontal Sync Adjust #92

Closed ziaddemir closed 3 years ago

ziaddemir commented 3 years ago

Hi, I just saw the new WonderSwan MiSTer core has the option to manually offset the position of the screen for the VGA output to help with CRT playback. This has been a thing with most of the Arcade cores for a while too, and I was hoping it might get added to the Game Boy and GBA cores as well.

I'm requesting this feature because for some reason, my CRT displays an on-screen message at all times when using the Game Boy and GBA cores. If I could just move the image out of the way a bit, it would completely solve the issue. Anyway, thank you for reading!

twitter_Ew6zljXXMAMVDS5

twitter_Ew6zlHcXMAItuFL

RobertPeip commented 3 years ago

Sorry, but i will not add it to the GBA core, as it already has too many config bits used.

7 pixel would also not be enough to move your overlay out of the image.

You can however build a custom version of the GBA core for yourself. Just edit the "V_START = 62" into something like "V_START = 80": https://github.com/MiSTer-devel/GBA_MiSTer/blob/master/GBA.sv#L1054

ziaddemir commented 3 years ago

Sorry, but i will not add it to the GBA core, as it already has too many config bits used.

7 pixel would also not be enough to move your overlay out of the image.

You can however build a custom version of the GBA core for yourself. Just edit the "V_START = 62" into something like "V_START = 80": https://github.com/MiSTer-devel/GBA_MiSTer/blob/master/GBA.sv#L1054

Thank you for the fast response. Unfortunately I'm not very programming-savvy, but I downloaded the GBA.sv you linked, changed the value in a text editor and then saved it as an RBF file like the other cores on my SD Card. I just get a black screen when I try to launch it though -- how would I go about building this custom core, if it's not too much to ask?

sorgelig commented 3 years ago

For GBA you can use vga_scaler mode with custom video modes (check MiSTer forum) and in custom video mode you may adjust the position of screen by defining specific blank values.

ziaddemir commented 3 years ago

For GBA you can use vga_scaler mode with custom video modes (check MiSTer forum) and in custom video mode you may adjust the position of screen by defining specific blank values.

I'm kinda hesitant to try this since using a mode my CRT isn't compatible with might damage it from what I understand. Plus just having a separate core for it like Robert suggested seems the most convenient.

mirkorean commented 3 years ago

separate core makes a lot of things difficult for you, as you need to always make your own build when something is released and you want to be up to date. that said, i build the change for you untested: https://github.com/mirkorean/GBA_MiSTer/releases/download/unstable-builds/GBA_unstable_20210707_3191.rbf

ziaddemir commented 3 years ago

separate core makes a lot of things difficult for you, as you need to always make your own build when something is released and you want to be up to date. that said, i build the change for you untested: https://github.com/mirkorean/GBA_MiSTer/releases/download/unstable-builds/GBA_unstable_20210707_3191.rbf

thank you so much, i'll test this asap! i hate to ask but if you could give me a quick rundown on how to build the core so i can do it myself in that scenario, it'd be super helpful.

i'd also appreciate more specific directions re: custom video modes if anyone has them, like i said, i wouldn't want to mess around with random numbers and resolutions and potentially damage my CRT.

sorgelig commented 3 years ago

i'd also appreciate more specific directions re: custom video modes if anyone has them, like i said, i wouldn't want to mess around with random numbers and resolutions and potentially damage my CRT.

Github is not discussion platform. Please use MiSTer forum. Custom video modes were discussed on forum.

RobertPeip commented 3 years ago

I will close here as a forum thread now exists.