MiSTer-devel / GBA_MiSTer

GBA for MiSTer
GNU General Public License v2.0
143 stars 44 forks source link

Small visual glitch in ALttP #96

Closed RichEsq closed 3 years ago

RichEsq commented 3 years ago

When playing A Link to the Past, at the "Choose a File" menu, press right on the D Pad on a selected game file. An options menu will appear allowing the user to choose the text speed and brightness. There is a small visual glitch on the lower left of this options menu in the form of a blinking vertical line.

This one seems easy to replicate, but please let me know if I can provide more information.

Thanks for all your great work!

RobertPeip commented 3 years ago

Cannot reproduce this at all. Tried with original BIOS, Homebrew BIOS, EU and US Version and all 3 save places. Nothing blinking here.

SHA1 of US-ROM for you to verify: A272055ABBBF6C26B0CD54C87395D01699589161

20210714_061622-Legend of Zelda, The - A Link To The Past Four Swords (U)  !

RichEsq commented 3 years ago

How exceedingly strange. Occurs reliably for me in the US Rom (same SHA1) on screen, but it doesn't appear in screenshots.

Photo and screenshots attached. 20210714_072648-Legend of Zelda, The - A Link to the Past   Four Swords (USA, Australia)

IMG_4828

RichEsq commented 3 years ago

It appears that it also occurs using the homebrew bios, but does not occur on a fresh game save. Save attached. Legend of Zelda, The - A Link to the Past & Four Swords (USA, Australia).sav.zip

wwark commented 3 years ago

Reproduce also on my side. Good catch ! It is not present on the real hardware.

SegaSnatcher commented 3 years ago

I reproduced the glitch as well.

RobertPeip commented 3 years ago

Can reproduce it with the savegame from RichEsq, will try to see what this is

wwark commented 3 years ago

I tested previous RBF. This issue is introduce at this version GBA_20200409.rbf. Previous versions don't have this glitch.

RobertPeip commented 3 years ago

Thanks for researching @wwark!

I found the problem. It's due to a change in a commit from 08.04.2020 not covering all possible paths from a change in 12.12.2019. Sometimes things haunt you for years :)

It's a small edge case, but could hit any game.

Lastest commit should fix it. At least it does for me. Testbuild attached.

Thanks to everyone for finding, reporting and testing!

GBA_alttp_sprites.zip

wwark commented 3 years ago

Thank you @RobertPeip for the quick fix. It fixed it also on my side ! Thanks again @RichEsq to report this issue