maij
commented
1 year ago I have implemented a DAC decay, similar to what is done in sameboy. This solves the issue, but may not be the root cause. There may be a cleaner solution.
This build has an extra menu option in Audio + Video to change the DAC decay rate. Max decay is the same as before, decaying immediately to ~0 V. Fast has a 6 ms decay to 0 V, Medium is 24 ms and Slow is 96 ms. 6 ms is what sameboy uses and I think that works perfectly. Gameboy_dac_decay_sel_20230418.zip
I would like to implement a DAC attack as well, but that was slightly more complicated. Not sure if there is are any noticeable examples where DAC attack is audible.
Will look into the games here: https://github.com/LIJI32/SameBoy/commit/3035f43428b15dbc75dff150646dd97425f91ec4
I have tested all of the games affected by DAC speed changes in Sameboy and have found that all of these roms did not have major (or even noticeable) audio problems due to noise. I found that Tarzan may have a slightly reduced noise level with the changes I've made, but it is slight. Not sure if this is the root cause for the Vigilante 8 noise or if something else should be done.
A release should be held off until this is resolved.
With the latest PRs the game Vigilante 8 (Rumble version) has a regression where the title screen has more background static than it did before in the latest stable release (Gameboy_20230225).
This has two (or more) potential causes:
I will first check which channel the noise is coming from (to confirm if it is the wav channel or not), then investigate further.