search

MiSTer-devel / MSX1_MiSTer

Computer MSX1
GNU General Public License v2.0
18 stars 9 forks source link

MSX2TEST Branch : Young Sherlock - The Legacy Of Doyle (ROM, MSX1) have issue to start #26

Open wwark opened 2 months ago

wwark commented 2 months ago

Hi,

On current MSX1 last official release, Young Sherlock - The Legacy Of Doyle works and detected automatically.

But with MSX2TEST Branch, last unofficial release, it is not detected automatically and we select ASCII8 mapper it doesn't boot.

Info of the rom: (sha1sum) 97e173dac64dbde7d6a60de7606cba0c860813db Young Sherlock - The Legacy Of Doyle.rom

Thanks,

tdlabac commented 2 months ago

Thanks for the report, I hope to release a new version soon that should address this.

Vampier commented 2 months ago

The N64 core has a database to identify 'mapper types' and settings. Would it be possible to use a same mechanism for the core now? I can create the database with SHA1Sum and RomMapper type.

vanfanel commented 2 months ago

Thanks for the report, I hope to release a new version soon that should address this.

I have no words for your work on the MSX core, and this comment gave me hope about it's completion! Many thanks for keeping the work on this! :)

tdlabac commented 2 months ago

A version that addresses this issue will soon be available after a long hiatus. I have rewritten the module responsible for loading ROMs and configuration. One of the new features is a CRC32 database with a mapper. Although SHA1 is a more robust solution compared to CRC32, it would require modifications in the main module. So, the ROM versus mapper issue is now resolved.

GuerreroNinja commented 2 months ago

Great news! I rarely load the old OCM core these days, your MSX core is far better for it's flexibility and compatibility. I will report any problems I find, although after fixing the border problem I have not found any (not intensive use or testing though).

Vampier commented 2 months ago

I can easily add a CRC32 value for most ROMs that I have. Let me know the format you want it in and it will be done. I have around 6000+ entries.On Aug 29, 2024, at 07:31, Molekula @.***> wrote: A version that addresses this issue will soon be available after a long hiatus. I have rewritten the module responsible for loading ROMs and configuration. One of the new features is a CRC32 database with a mapper. Although SHA1 is a more robust solution compared to CRC32, it would require modifications in the main module. So, the ROM versus mapper issue is now resolved.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

tdlabac commented 2 months ago

@Vampier At this moment, it is too early to generate the DB. Not all the requirements I need to know, apart from the ROM mapper, have been defined yet. For example, the size of the SRAM, additional hardware (SCC: SCC+), the start of the ROM, etc.

Vampier commented 2 months ago

Got it - sram size and SCC usage is linked to mapper type.  SCC+ was only used in SD snatcher (disk game) Once you’re ready let me know On Aug 29, 2024, at 09:58, Molekula @.***> wrote: @Vampier At this moment, it is too early to generate the DB. Not all the requirements I need to know, apart from the ROM mapper, have been defined yet. For example, the size of the SRAM, additional hardware (SCC: SCC+), the start of the ROM, etc.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Vampier commented 2 months ago

@Molekula since it didn't take much I've added CRC32 to the ROMDB and created a page that generates a text file with CRC32[TAB]Mapper[EOL]

https://romdb.vampier.net/msxcoredb.php

I can keep on building on this once you have the requirements.

On Thu, Aug 29, 2024 at 9:58 AM Molekula @.***> wrote:

@Vampier https://github.com/Vampier At this moment, it is too early to generate the DB. Not all the requirements I need to know, apart from the ROM mapper, have been defined yet. For example, the size of the SRAM, additional hardware (SCC: SCC+), the start of the ROM, etc.

— Reply to this email directly, view it on GitHub https://github.com/MiSTer-devel/MSX1_MiSTer/issues/26#issuecomment-2318377521, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAYZDEVPROJBTX7XDU7PQTZT5HJXAVCNFSM6AAAAABNCTGW52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJYGM3TONJSGE . You are receiving this because you were mentioned.Message ID: @.***>