search

MiSTer-devel / MSX_MiSTer

MSX for MiSTer
41 stars 22 forks source link

[Request] Update to latest OCM 2019.05.20 pack releases? #2

Closed MP2E closed 5 years ago

MP2E commented 5 years ago

I'm a big fan of this core, and as I'm getting to know it better, I noticed that we're a release behind the upstream One Chip MSX project. Could this be updated? It features a fix for the VDP wait controller, along with some other things.

Thank you! I hope to be able to help with this stuff in the future instead of having to ask, still working through the basic Verilog tutorials :)

MP2E commented 5 years ago

update: managed to backport 2 changes to help out over in #3

I don't know if the other changes in v3.7.1 are relevant to MiSTer or not

It talks about fixing Luminance calibration and a bug in the line buffer for the VGA upscan converter, but does MiSTer use those things from the core?

sorgelig commented 5 years ago

MiSTer uses scandoubler from MSX unlike in other cores. So i think scandoubler fixes also relevant to MiSTer

MP2E commented 5 years ago

thanks for the pointer! I submitted another PR, but will look at v3.7.1 again later to see if there are more changes to port.

MP2E commented 5 years ago

I've got some more changes in mind to submit as pull requests, but I think all the relevant things from v3.7.1 are ported so I will close this

sorgelig commented 5 years ago

Do you want to make more PR before release?

MP2E commented 4 years ago

Oh. I missed this response, sorry about that! I would like to remove all async clocks, fix the scandoubler bug without introducing any more issues, and attempt to fix SD Snatcher's intro timing before next release.

It seems the VDP Wait Controller timing update from OCM-PLD 3.7.1 caused SD Snatchers intro to end slightly out of sync with the music. I am hesitant to just revert, because the new vdp wait timings do fix a few games.