MiSTer-devel / Main_MiSTer

Main MiSTer binary and Wiki
GNU General Public License v3.0
3.05k stars 330 forks source link

Scandoubler scanlines fx fail on some cores when video is rotated #320

Closed dfilskov closed 1 year ago

dfilskov commented 3 years ago

When you rotate the video signal in a core's OSD the scanlines fx for the Scandoubler setting stops working.

birdybro commented 3 years ago

I believe this is due to how ascal is handling the OSD's HQ2x/Scanlines effects. And if you use vertical scanline filters instead as an alternative, I think I remember it will look very bad if you don't use integer scaling, as even though the image is rotated it's still scaling vertically to your display as opposed to horizontally. So download the filters from the github, go to the scanlines vertical folder, and when you rotate OSD it should work. If it doesn't then something must have changed not too long ago.

https://github.com/MiSTer-devel/Filters_MiSTer

https://github.com/MiSTer-devel/Filters_MiSTer/tree/master/Filters/Scanlines%20(Vertical)

There's the vertical scanlines you should try to put in /media/fat/Filters folder. Example of vertical scanlines filter below:

image

dfilskov commented 3 years ago

Wait - it's only some cores. E.g. BombJack and Donkey Kong - custom filters seem to work on all cores but the OSD's Scandoubler fx 'scanlines' work on other cores (but not the two above) like Arkanoid and Burning Rubber.

sorgelig commented 3 years ago

Not all arcade cores updated to latest framework yet. Updated cores have scanlines FX working for both horizontal and vertical orientations.

dfilskov commented 3 years ago

Are you sure this is the case for the non-custom scandoubler FX? - the "built-in" setting in all cores (not the ones where you load an fx from storage)

jotego commented 1 year ago

I suppose this issue is fixed by now (2 years later) on the individual cores. I propose to close it.