search

MiSTer-devel / Main_MiSTer

Main MiSTer binary and Wiki
GNU General Public License v3.0
3k stars 320 forks source link

Change to order of ROM directory searching #590

Open Paradox opened 2 years ago

Paradox commented 2 years ago

This is a small, probably inconsequential, for most users, change, and wouldn't affect most people, but, I feel it is a completely logical change.

At the moment, the core looks for ROM directories, and gives priority to the first matching directory it runs across, while scanning. The current search order puts /media/usb0 as top priority, and puts /media/fat/games as lowest priority, the one change I would propose is that you enumerate the usb list in reverse of current, so that the top priority would become usb5, instead.

I realize this is not an issue at all, for most people, and, fully expect it to have a low priority, but, I still think it should have been the logical order, from the beginning. I also realize that making sure the ROM directory that you want, only exists on the media you want it to be detected at is important, I still think it makes sense to change this.

sorgelig commented 2 years ago

it's mostly esoteric request. I suggest to make games folder only on one USB drive, or at least have games folder for specific core only on one USB drive. Then only this drive will be detected for specific core.

Paradox commented 2 years ago

It would actually be nice to have unioning to combine any duplicate directories. ;)

jotego commented 1 year ago

I don't get the point of this. Are you trying to get /media/fat/games parsed first and then other external devices? I have seen many reports of people running into problems when a folder was present in more than one device. But I haven't got issues related to that in a few months. I guess that may be fixed now.

I suggest closing this issue. @Paradox you may consider opening a new one with a more detailed proposal of a folder search logic if you're still running into problems.

sorgelig commented 1 year ago

I plan to support games folder in multiple locations. I keep it in mind till i figure out all quirks.