search

MiSTer-devel / Main_MiSTer

Main MiSTer binary and Wiki
GNU General Public License v3.0
3.03k stars 329 forks source link

Buggy folder names inside a zip container #842

Closed rodribyte closed 11 months ago

rodribyte commented 12 months ago

Hi there,

Hope you are doing well.

I would like to report an issue related to folder names while navigating inside a zip container. The problem occurs when inside the zip there are two folders with similar names, for example: Folder1 Folder1234

In this case, when entering Folder1, the first name that appears in the file list is "234".

I hope I have a solution because for me it is ideal to organise my roms in this way. Let me know if you need any more information.

Thanks!

PS: Folder1234 could also be a rom of the same name, the effect is the same.

rodribyte commented 12 months ago

image image

sorgelig commented 12 months ago

hmm.. strange that you are the first one who found it. I will check.

rodribyte commented 12 months ago

Maybe there are very few of us who see the need to create folders inside a zip file. Anyway, it seems strange to me too. I warned other users, but it seems that they still don't do the test.

El lun, 23 oct 2023 a las 12:00, Alexey Melnikov @.***>) escribió:

hmm.. strange that you are the first one who found it. I will check.

— Reply to this email directly, view it on GitHub https://github.com/MiSTer-devel/Main_MiSTer/issues/842#issuecomment-1775404593, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDOXUWBB7ULNNVLGLKC3MJ3YA2BCRAVCNFSM6AAAAAA6MAZNJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZVGQYDINJZGM . You are receiving this because you authored the thread.Message ID: @.***>

-- Rodrigo Saavedra Doblaje / Traducción y adaptación.

sorgelig commented 11 months ago

it seems introduced in commit fixing handling of zips with absent folder entities. I have to understand new logic..

sorgelig commented 11 months ago

Should be fixed now. Please test unstable build.

rodribyte commented 11 months ago

It works!!! Thank you, you are the best. (edit: I may not have tested it in depth)

Zet-sensei commented 11 months ago

After some tests on my side, the last changes broke the single zipped files support on cores. You can't load anymore games & the cores only see a blank folder instead of loading files when selecting a ZIP file.

Reverting to commit https://github.com/MiSTer-devel/Main_MiSTer/commit/4fab9a5aa78a333941ab19398e6e2610396f0c12 fixes the issue on those files.

EDIT : Issue confirmed by another user on Discord (Count Duckula) just a moment ago.

sorgelig commented 11 months ago

probably you mentioned a wrong commit - it has nothing to do with zip files. anyway, i will check zip with single file

sorgelig commented 11 months ago

try new fix.

Zet-sensei commented 11 months ago

Fixed with https://github.com/MiSTer-devel/Main_MiSTer/commit/bf2eb381ba775312e2ae0e7175c5000e1af9a651

Thank you.