MiSTer-devel / Minimig-AGA_MiSTer

142 stars 54 forks source link

[Request] Distinct scanlines filter for RTG & OCS/ECS/AGA #142

Open bidinou opened 2 years ago

bidinou commented 2 years ago

Hi !

Would it be possible to apply a different scanlines filter (and eventually, shadow mask) to the RTG output ?

Indeed, as many of us I think, I use a standard RTG workbench to start apps & browse my games collection while retaining the maximum amount of chip ram for starting them. I use a scanlines filter for games.

The way it works currently, I have to use integer scaling for RTG otherwise I get scaling artifacts with the scanlines. Which makes the display super tiny unless I use a low resolution of 640x480 which is not super pleasant. Or I can use 1920x1080 -- but again, it's so tiny my eyes hurt :-)

Alternatively, if there cannot be a distinct scanlines filter selection, could there be a way to disable filters for RTG and/or have a distinct internal scandoubler FX ?

Cheers & thanks a lot for considering this !

sorgelig commented 2 years ago

Shadow masks will be available for all cores. Scanlines will get special support to make it good looking, but it won't work for RTG unfortunately.

bidinou commented 2 years ago

Hi ! Thanks for the reply, Sorge. I understand but is it possible to prevent RTG from being affected by them when I select scanlines for non-RTG pieces of software while running the system in RTG mode ?

sorgelig commented 2 years ago

i will see

limi commented 2 years ago

Ah, there was already a bug filed on this, great.

Yes, there seems to have been a regression here — the original RTG implementation would disable scanlines when you selected any of the RTG resolutions. Currently, it works in some resolutions (maybe by accident?) and not in others. Here’s what I see on my setup:

sorgelig commented 2 years ago

there are 2 types of scanlines: 1) scanlines by Scandoubler FX provided by core 2) scanlines made by video scaling filters.

So it's important to understand that we are talking only about (1). New scanlines implementation applied to only non-RTG video. So make sure you're using RTG. I have no idea how you get scanlines on RTG on new release as i'ts simply impossible.