search

MiSTer-devel / NES_MiSTer

GNU General Public License v3.0
174 stars 75 forks source link

Add SNAC support for 3d glasses, whitespace cleanup #316

Closed Kitrinx closed 2 years ago

antoniovillena commented 2 years ago

The description is incomplete. The main reason for this commit is SNAX support for misteraddon devices: https://misteraddons.com/products/serial-native-accessory-converter-snac

Also the implementation is the same proposed by Neurorulez two years ago: https://github.com/MiSTer-devel/NES_MiSTer/pull/158

On that moment Sorgelig accepted initially the PR, but you rejected with the reason of not enough wires and broken compatibility. Now you use same implementation but swapping pins, so you are broken compatibility with our DB9 implementation.

Kitrinx commented 2 years ago

There's some other non-breaking adjustments to more fully use famicom ports that blue asked me for some time ago as well. He manages the SNAC hardware so I made the changes he wanted. Did you have some point, or are you just making some historical record?