MiSTer-devel / NES_MiSTer

GNU General Public License v3.0
174 stars 75 forks source link

FDS: Tonkachi Editor does not function #385

Closed Thelypody closed 3 months ago

Thelypody commented 4 months ago

NES core: 20240408, Main: 20240505

Tonkachi Editor is an unlicensed disk released for the Family Computer Disk System in 1987. The primary function of the program is a hex editor, but the disk also gives you an opportunity to insert a copy of Super Mario Bros. (1) for FDS to overwrite it with prepackaged new content, creating a game version commonly known as Tonkachi Mario, considered to be one of the earliest romhacks of the game.

I've tried to replicate the process of creating a Tonkachi Mario disk in an authentic way. For this purpose I've merged two disk images: Tonkachi Editor (Japan) (Unl).fds (CRC32: BEA8B9A2) Super Mario Bros. (Japan).fds (CRC32: E0890CF2) The resulting new file (CRC32: 35702D8D) has the editor program on side A and the game on side B and both sides properly boot separately when swapping disk sides in the core on console startup.

Launching the side A prompts you to eject the Tonkachi Editor disk. 20240721_161815-Tonkachi Editor + Super Mario Bros  (Japan) (Unl) Holding the FDS button (or releasing it to swap sides to Super Mario Bros.) shows us two options. The first is a hex editor, the second is a Tonkachi Mario creation tool. 20240721_161835-Tonkachi Editor + Super Mario Bros  (Japan) (Unl) Selecting the second option starts an unfortunately lengthy text scroll accompanied by music. You are supposed to insert the game disk while it is going. 20240721_161916-Tonkachi Editor + Super Mario Bros  (Japan) (Unl) After the text scroll a brown screen appears, indicating supposed activity. Unfortunately, at this point the program freezes. Rotating disk sides with the FDS button asks us to insert disk again, but nothing happens regardless. 20240721_131043-Tonkachi Editor + Super Mario Bros  (Japan) (Unl) I've found a video demonstration of Tonkachi Editor on YouTube, which shows that at this point the program is supposed to take a few seconds to overwrite the disk and then show a blue screen saying "END". https://youtu.be/kqmQ6ljEghA?si=Xp5Q-JPJVMvzsmFo&t=334 On MiSTer the brown screen shows no signs of disk activity and stays permanently on the brown screen. No save file is created for the disk image. Trying to access the hex editor from the main menu shows similar results, with the program constantly asking to insert a game disk.

paulb-nl commented 3 months ago

This is fixed with #387. The hex editor works and Tonkachi Mario also works.