search

MiSTer-devel / NeoGeo_MiSTer

NeoGeo for MiSTer
GNU General Public License v2.0
148 stars 77 forks source link

Kof94 Graphics Glitches All Over The Place #110

Closed mikey1964 closed 2 years ago

mikey1964 commented 4 years ago

just play the game and you can see parts of the animation appear in different parts of the screen you can really see it happen the most in the Korean team stage were you fight Kim

Dubon77 commented 3 years ago

Could you take some screengrabs of this? Ive tried to reproduce it but havent noticed anything. It would also be usefull to specify what rom youre using.

mikey1964 commented 3 years ago

i tried both the darksoft rom set and the world neo set . my ram passes all test only the neogeo core do i see this and some other games like pulstar but kof 94 is the worst for me the more you move and do combos the more the glitches appear all over the place. https://www.youtube.com/watch?v=xgFssG70s48 this was upload by somebody else go to the end were they start to fight 1:06 time stamp

Dubon77 commented 3 years ago

Yeah i dont get those. What ram module do you have and have you run the memtest? I think in some cases reseating the ram has helped.

mikey1964 commented 3 years ago

yes i ran the memtest and i got the 128

Dubon77 commented 3 years ago

What speed did it pass consistenly? Have ou tried reseating it?

mikey1964 commented 3 years ago

What speed did it pass consistenly? Have ou tried reseating it?

it stays stable at 140 with no errors i have no problems with any other cores its just kof 94 and some other neogeo games the glitches happen so fast you have to have good eyes to catch them

Dubon77 commented 3 years ago

Did these glitches get introduced since the 28 september build or were you experiencing them with previous builds aswell? Would you be willing to delete it and download the latest manually?

mikey1964 commented 3 years ago

Did these glitches get introduced since the 28 september build or were you experiencing them with previous builds aswell? Would you be willing to delete it and download the latest manually?

which one you want me to install i have the last update of the core i dont rember when the glitches begin

Dubon77 commented 3 years ago

There was an update on the 28th, the day you submitted this error. So its worth deleting that build and trying the build before for this error. Its also worth redownloading the latest build, ive had it happen that redownloading a core fixed issues. Im positive i cant see the glitches on my mister witch also has 128MB sdram. Ive also asked others on discord.

mikey1964 commented 3 years ago

There was an update on the 28th, the day you submitted this error. So its worth deleting that build and trying the build before for this error. Its also worth redownloading the latest build, ive had it happen that redownloading a core fixed issues. Im positive i cant see the glitches on my mister witch also has 128MB sdram. Ive also asked others on discord.

i went with NeoGeo_20191014.rbf i see no glitches and also i see no text flicker either

Dubon77 commented 3 years ago

Ok can you redownload the latest build?

mikey1964 commented 3 years ago

Ok can you redownload the latest build?

yes i did same bugs it made no diffrence

Dubon77 commented 3 years ago

Ok well the only thing left to do is try all the older builds untill you find out where the bug was introduced. There is some variance in de10 nano hardware, there are some bugs in Other cores where only some users were affected, witch got fixed over time, so maybe this is similar. if you can show tell them in witch version of the core the problem started maybe it can be fixed

Dubon77 commented 3 years ago

Right, well after playing the korea stage multiple times i think i noticed this bug too. As you said you have to be real fast to notice it. This 100% doesnt happen on real hardware right?

mikey1964 commented 3 years ago

Right, well after playing the korea stage multiple times i think i noticed this bug too. As you said you have to be real fast to notice it. This 100% doesnt happen on real hardware right?

i never seen it happen in real hardware dont have one to check Oct 14, 2019 Release 20191014. - no bugs and letters do not flicker Nov 13, 2019 Release 20191113. - i get the bugs you see on the videos doesnt seem as bad also the letters flicker like in issues "KOF 94 Japanese flickering text #73" maybe same problem

Dubon77 commented 3 years ago

This looks like a regression, cant find any other bugs that are related though

advert665 commented 3 years ago

I also have this bug on KOF 94, especially on the first part of the final stage against Bernstein. The player's animations flicker either around the character or at the bottom of the screen. Unibios 4.0 & Japanese/AES in bios settings.

tutifrutas commented 3 years ago

Right, well after playing the korea stage multiple times i think i noticed this bug too. As you said you have to be real fast to notice it. This 100% doesnt happen on real hardware right?

i never seen it happen in real hardware dont have one to check Oct 14, 2019 Release 20191014. - no bugs and letters do not flicker Nov 13, 2019 Release 20191113. - i get the bugs you see on the videos doesnt seem as bad also the letters flicker like in issues "KOF 94 Japanese flickering text #73" maybe same problem

I tracked it down to this commit https://github.com/MiSTer-devel/NeoGeo_MiSTer/commit/b4f924d1f8652a6a3ea5c157edca8c4371f1560a if I get latest from master, revert this commit and build the core the graphic glitches are gone.

compiled core https://github.com/tutifrutas/NeoGeo_MiSTer/blob/master/releases/NeoGeoKof94_20210905.rbf

mikey1964 commented 3 years ago

so far the text flicker and the animations appearing in different parts of the screen are gone its fix

sorgelig commented 3 years ago

That commit cannot be reverted as it's important SDRAM timing fix. Probably needs some fixes in other places to accomodate additional clock cycle. I will try to fix it.

PepAlacant commented 3 years ago

The real cartridge doesn't do that. The NEOSD ( randomly, depends on reset the machine ) and Bootleg carts do.

sorgelig commented 3 years ago

try this build: NeoGeo.zip

PepAlacant commented 3 years ago

This one works good KOF 94. This build has not the fixes that GreyRogue did for a layer missplacement in Breakers Revenge, Kabuki Klash, and Kof 2002.

Dubon77 commented 3 years ago

That build by greyrogue was only a testbuild released on discord. Those fixes were only a hack implemented to track down the underlying issue, so were not comitted to neogeo repo.

PepAlacant commented 3 years ago

Ah ok ok ! I understand. Anyway... Kof 94 is fixed. No more flying graphics and no more texts issues.

sorgelig commented 3 years ago

great!

mikey1964 commented 3 years ago

yes its fix after playing for about 2 hours no more text flicker and the animations appearing and disappearing in different parts of the screen are fix now thank you

tutifrutas commented 3 years ago

try this build: NeoGeo.zip

Thanks, it works, in kof94 all the text flicker and graphic glitches are gone.

mikey1964 commented 2 years ago

after the update this issue is back and NeoGeo_MiSTer/issues/73 ------ has been fix with the new Release bulid 20220403 on 4/3/2022

mikey1964 commented 1 year ago

hi sorgelig the update cause this issue to come back again

sorgelig commented 1 year ago

It means core has metastability issue which can be fixed only after major re-write to comply with FPGA rules. It can be temporarily "fixed" by trying other SEED values for compilation. But any newer build may bring issue back...

PepAlacant commented 1 year ago

Maybe would be good to try to fix the new releases by now... but sadly I have no hope about the future rewrite, but who knows ...

PepAlacant commented 1 year ago

The issue is back. It affects only the MVS/AES version, not the CD Version. I think Gyurco did a rework of the core clocks for MiST conversion, I don't know if it could be helpful for definetively fix the MiSTer Core.

Thanks !