search

MiSTer-devel / NeoGeo_MiSTer

NeoGeo for MiSTer
GNU General Public License v2.0
146 stars 78 forks source link

Neo Geo core pitch sound issues, as well as sound speed. #111

Closed Bocop closed 2 years ago

Bocop commented 3 years ago

Sound in many games has wrong pitch and even shifting pitch in Blazing Star music. It is definitely there and noticable. It sounds like the music slows down and speeds up changing pitch ever so slightly.

rsn8887 commented 3 years ago

I also hear this in Blazing Star.

rsn8887 commented 3 years ago

I think this might be a duplicate issue, see here https://github.com/MiSTer-devel/NeoGeo_MiSTer/issues/60

Bocop commented 3 years ago

I think this might be a duplicate issue, see here #60

Yeh this seems to be ongoing because people can still hear it in Blazing Star and a few other games. I just read through that whole thread and it is awesome that @jotego is working through it with people who can hear this. The Neo Geo core is my favorite and I think it's amazing.

MJY71 commented 3 years ago

It's really noticeable during the title music for Pulstar as well, about 30 seconds in after loading the game once the gameplay demo starts and there is action on-screen (shots being fired, ships exploding, etc.). The music speed and pitch really starts dragging as though it's being played back on an analog reel-to-reel player with a dirty head.

It doesn't exhibit this behavior when the music is played back by itself in the game's Options screen in AES mode.

MonokromFR commented 3 years ago

Hi all ! Can't compare as i never own Pulstar on real hardware but notice something "wrong" in Pulstar demo sound. Issue seems to disappear when soundtrack are played (alone) on AES mode or in Unibios jukebox.

This is the same issue as https://github.com/MiSTer-devel/NeoGeo_MiSTer/issues/60 Pitch issue appears when SFX are played at the same time.

This was more noticable before Last Neogeo core update (2020-09-28)

Bocop commented 3 years ago

Is it still a thing after the last update? did the last update help anything? Is there an update that also has not been released yet?

MJY71 commented 3 years ago

This issue thread was created only 8 days ago, and the last release was 24 days ago. There have been no pull requests since then, so it's still an issue.

Bocop commented 3 years ago

@MJY71 That is too bad. Ugh.

ghost commented 3 years ago

I also notice this, here there is an audio capture:

blazingstar.zip

Check out :15, :19, :25 and :27.

Bocop commented 3 years ago

Hi, this is the author of JT12, which was forked on this repository to handle the sound. If you can produce VGM files of the relevant music tracks where the problem occurs I will check if the problem is in JT12. Thank you.

@jotego @pacoarcade Just put up a sound sample of the issue. Any chance you could take a look at this? thank you so much!

ghost commented 3 years ago

@Bocop I already uploaded an audio capture via recorder. If needed I could look to make the recording via line in.

Bocop commented 3 years ago

Oh, I was referencing the one you posted, thank you so much!!!

On Wed, Jan 20, 2021 at 10:00 AM pacoarcade notifications@github.com wrote:

@Bocop https://github.com/Bocop I already uploaded an audio capture via recorder. If needed I could look to make the recording via line in.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MiSTer-devel/NeoGeo_MiSTer/issues/111#issuecomment-763681324, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOEWRHA2RF7H7MHPMAQ2LLS23VXHANCNFSM4SQT6PKQ .

okami2012 commented 3 years ago

Excuse me ,I saw NEO GEO core sound is run a slower than video like The King of Fighter 98. In the Opening Video

Bocop commented 3 years ago

Good to know! I would love if this core got an update that ironed out any of the remaining sound issues.

On Mon, Mar 29, 2021 at 8:33 AM okami2012 @.***> wrote:

Excuse me ,I saw NEO GEO core sound is run a slower than video like The King of Fighter 98. In the Opening Video

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MiSTer-devel/NeoGeo_MiSTer/issues/111#issuecomment-809339854, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOEWRGLVEQUCMBCSDB76IDTGBXQJANCNFSM4SQT6PKQ .

stainmage commented 3 years ago

Hello, since this thread has an older duplicate, I post my comment there too 👍

Same problem here but I noticed the pitch variation in every game I tested : Art of Fighting, Kof98, Snk vs Capcom...

Here is a comparison between the latest mister core 128mb, and a real neo geo with Darksoft cartridge, it's the same romset :

https://drive.google.com/file/d/1szaYSXKVfdZ9bnq_-mSRIFflALAyzSgA/view?usp=drivesdk

https://drive.google.com/file/d/1sqCVhe7P5jOVbZtC4V_RC36oJ95ZnUSW/view?usp=drivesdk

You can sense after pressing the start button how the second note drifts away in some kind of modulation while the computer shows the tutorial. The music in the core isn't consistent, it's out of tune by moments, as if it struggles to stay in the tempo but not with the correct speed. I don't notice this problem in the real hardware with Darksoft cartridge. I don't have the original, but even in mame it doesn't happen.

There are many parts of the game that has the same problem.

Hard to tell in the video but IRL it's easy to spot, sounds like a tape slow down

Cheers

Matt-Retrogamer commented 3 years ago

Hi guys,

Any update of this topic ? It was also reported by a couple of users on our Discord channel.

thx!

Bocop commented 3 years ago

I have seen nothing in a really long time. Was hoping it would be taken care of. :-(

On Thu, Jun 17, 2021 at 5:50 AM Matt-Retrogamer @.***> wrote:

Hi guys,

Any update of this topic ? It was also reported by a couple of users on our Discord channel.

thx!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MiSTer-devel/NeoGeo_MiSTer/issues/111#issuecomment-863098875, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOEWRAXN3TBAW3TYDMOVWLTTHAOPANCNFSM4SQT6PKQ .

mirkorean commented 3 years ago

There was a fix merged for this. Maybe you guys can try the build from here: https://github.com/MiSTer-unstable-nightlies/NeoGeo_MiSTer/releases/download/unstable-builds/NeoGeo_unstable_20210811_ba00.rbf and report back?

MonokromFR commented 3 years ago

There was a fix merged for this. Maybe you guys can try the build from here: https://github.com/MiSTer-unstable-nightlies/NeoGeo_MiSTer/releases/download/unstable-builds/NeoGeo_unstable_20210811_ba00.rbf and report back?

THAT IS A GREAT NEW !!!

Works like a charme ! I don't hear any f***ng warble sound anymore.

Bocop commented 3 years ago

Is this included in the updater now?

On Wed, Aug 11, 2021 at 4:48 PM Mirko Rean @.***> wrote:

There was a fix merged for this. Maybe you guys can try the build from here: https://github.com/MiSTer-unstable-nightlies/NeoGeo_MiSTer/releases/download/unstable-builds/NeoGeo_unstable_20210811_ba00.rbf and report back?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MiSTer-devel/NeoGeo_MiSTer/issues/111#issuecomment-897142005, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOEWRHKAAJZLVA6WZQW2J3T4LO3LANCNFSM4SQT6PKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

stainmage commented 3 years ago

Hi, thanks a lot for this fix, I can confirm I don't hear the problem anymore in Art of Fighting,,i'm sure it's not merged yet in the stable branch

Bocop commented 3 years ago

I'm stuck at work at the moment, can anyone try Pulstar and Mark of Wolves? I know they were 2 games with some funny pitch issues.

darkphoenixfox commented 3 years ago

Pulstar sounds perfect now (and AOF3 too, which also had clear issues)

Bocop commented 3 years ago

Awesome, thanks! Wow, this release is going to be amazing.

On Fri, Aug 13, 2021 at 11:26 AM Jon Cahill-Torre @.***> wrote:

Pulstar sounds perfect now (and AOF3 too, which also had clear issues)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/MiSTer-devel/NeoGeo_MiSTer/issues/111#issuecomment-898542348, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIOEWRH2DSXDUXLH2M2GD4DT4U2TXANCNFSM4SQT6PKQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

AtomicShroom commented 3 years ago

Yup, sounds great with the latest change! Thank you so much! :D

Dubon77 commented 2 years ago

Please close this issue