MiSTer-devel / NeoGeo_MiSTer

NeoGeo for MiSTer
GNU General Public License v2.0
148 stars 77 forks source link

Left-most vertical line in 320 res games blacked out: #118

Closed Firebrandx closed 3 years ago

Firebrandx commented 3 years ago

I happened to notice the left-most vertical line of graphics is blacked out on 320-res games. Appears to not matter what game it is. I checked on my AES console and it shows all 320 lines, so this has to be a core bug.

sorgelig commented 3 years ago

on which game you test it?

Firebrandx commented 3 years ago

Fatal Fury Special, Fatal Fury, Magician Lord. It appears to not matter what game it is. If it's a 320 game, the first vertical line on the left is black, so you end up seeing 319x224.

SegaSnatcher commented 3 years ago

I know this is a dumb question, but you have 320 mode enabled in the OSD correct? Because there is also a 304px mode in the OSD that might be turned on by default.

Firebrandx commented 3 years ago

Yes I can EASILY tell the difference between 304 and 320. I used my E1S card to count the pixels anyway.

sorgelig commented 3 years ago

I'm already not sure what do you mean.. Is there something on screen where you can clearly see the left most column is missing? Of you just look at some tool? USB console debug log shows the video has 320 pixels. Would be good to get some comparison screenshot where it's visible

Firebrandx commented 3 years ago

Look, it's real simple: The left vertical line is blacked out. It may show up in logs, but it's physically blacked out on actual viewing. Do I need to make some screenshots to prove it?

Firebrandx commented 3 years ago

Here are direct captures of the 319x224 bug versus correct 320x224:

http://www.firebrandx.com/downloads/proof/MiSTer_Neo_Geo_319_Bug.png

http://www.firebrandx.com/downloads/proof/Neo_Geo_320.png

As you can see, the left-most vertical line is missing (likely just colored black on the footprint of 1920x1080).

SegaSnatcher commented 3 years ago

It looks like the Neo-Geo core is shifted to the left and is likely why there is a missing line. Good catch.

Kitrinx commented 3 years ago

I've double checked, left most column is definitely missing for 320 wide games.

sorgelig commented 3 years ago

i will check if i can fix it.

sorgelig commented 3 years ago

NeoGeo.zip try this build

Firebrandx commented 3 years ago

New build works great! All 320 lines show up properly now. Thanks!