MiSTer-devel / NeoGeo_MiSTer

NeoGeo for MiSTer
GNU General Public License v2.0
145 stars 76 forks source link

The Super Spy Audio Bug #164

Closed fignutz closed 1 year ago

fignutz commented 2 years ago

As of the 20220403 release, "The Super Spy" has a bug where certain portions of the audio's music has extremely high-pitched tones play intermittently during both gameplay and attract sequences. This phenomenon only happens during the main execution of the game logic and not boilerplate logic such as the Neo Geo attract logo music.

To Recreate:

  1. Use/load "DarkSoft Roll-Up Pack" version of The Super Spy
  2. Set Uni-Bios 4 to U.S.A./ARCADE
  3. Let game play in attract mode and listen.
PepAlacant commented 2 years ago

I cannot get the error. What it's exactly. Which instrument ? I'll compare with real hardware. In first instance, I listen it correctly.

fignutz commented 2 years ago

I'm not sure which instrument is playing wrong by name. If I had to guess, its what ever instrument that plays the main theme lead in music in the high-pitched areas right before the announcer exlcaims "The Super Spy". I own the MVS cart myself, and I can confirm this high-pitched squeal does not exist on my MVS playthroughs.

That said, I use the commercial (previously non-free) older 3.x UNIBIOS on my 4 Slot cabinet, and have not upgraded to the "non-commercial" (free) UNIBIOS 4.0 that is pulled into the MiSTer via the 'update_all.sh" script. I point this out because, until a certain update occurred with the UniBIOS v3 (I think 3.1 to 3.5?), the "hands/fists" or the "Main title logo" of "The Super Spy" would not show up/be invisible during the attract sequence of the game.

PepAlacant commented 2 years ago

I cannot reproduce these pitches in my MiSTer.

fignutz commented 2 years ago

That's fine, but I'd like to see if @sorgelig or @jotego can replicate this issue, as I am still seeing this phenemenon. This is the only NeoGeo game this happens with, as all of the other ones test fine.

sorgelig commented 2 years ago

This core has some design flaw using async clocks which may introduce issues for some (not all) users. It cannot be simply fixed. Core needs some re-writing. @furrtek has plans to do it, so let's wait for it.

fignutz commented 2 years ago

Thanks for that insight @sorgelig; much appreciated. FWIW, I am still going to try downgrading my BIOS to the version I use with my real MVS just to see if the issue persists. Again, this may be moot given your note on async clocks, but I'd like to rule it out all the same.

Dubon77 commented 1 year ago

@sorgelig @furrtek fwiw, the developer who ported this core to analogue pocket claims to have fixed this design flaw, however he doesnt have a mister and so will not backport these changes himself. The repo is at https://github.com/Mazamars312/Analogue_Pocket_Neogeo

sorgelig commented 1 year ago

Mazamars312 is furrtek? I don't think so. Also furrtek has MiSTer. If we talk about design flaw which means async clocks, then it's not fixed. All async clocks are there. As for specific issue - need further checking. I don't have Analogue Pocket to verify it. Since async clocks give many race conditions in core, it can be "fixed" for some users but not for everyone.

fignutz commented 1 year ago

Ty for the clarification, @sorgelig . As of today, even with my legacy UniBIOS I use on my 6-Slot MVS board, I still get the high-pitched sound in certain musical beats/hits of the music and SFX of this title on the MiSTer (TBC, the sound is completely normal/fine on my MVS boards). FWIW, the ear-piercing sounds happen at exactly the same spot regardless of the BIOS I'm using under the hood. If there's a more concrete way that I can isolate this problem for troubleshooting/research purposes, please let me know.

kold669 commented 1 year ago

It happens also on Ghost Pilot, same high pitched notes as Super spy

paulb-nl commented 1 year ago

What a coincidence, Super Spy and Ghost Pilots both are reported as "(fixed sound)" on the December 2021 menu update for the Darksoft cart here: https://www.arcade-projects.com/threads/darksofts-multimvs-latest-firmware-menu-and-instructions.5101/#post-73601

They changed the vroma0 file so that the vromb_offset is at 0x200000 instead of 0x280000.

Try to use an older rom from the 2020 pack or change the vromb_offset in the romsets.xml file.

You can also try the mame roms with these in the xml:

<romset name="gpilots" pcm="0" altname="Ghost Pilots" publisher="SNK" year="1991">
        <file name="020-p1.p1" index="4"/>
        <file name="020-p2.p2" index="5"/>
        <file name="020-s1.s1" index="8"/>
        <file name="020-c1.c1" index="64"/>
        <file name="020-c2.c2" index="65"/>
        <file name="020-c3.c3" index="68"/>
        <file name="020-c4.c4" index="69"/>
        <file name="020-m1.m1" index="9"/>
        <file name="020-v11.v11" index="16"/>
        <file name="020-v12.v12" index="18"/>
        <file name="020-v21.v21" index="48"/>
    </romset>
<romset name="superspy" pcm="0" altname="Super Spy, The" publisher="SNK" year="1990">
        <file name="011-p1.p1" index="4"/>
        <file name="sp2.p2" index="5"/>
        <file name="011-s1.s1" index="8"/>
        <file name="011-c1.c1" index="64"/>
        <file name="011-c2.c2" index="65"/>
        <file name="011-c3.c3" index="68"/>
        <file name="011-c4.c4" index="69"/>
        <file name="011-m1.m1" index="9"/>
        <file name="011-v11.v11" index="16"/>
        <file name="011-v12.v12" index="18"/>
        <file name="011-v21.v21" index="48"/>
    </romset>
kold669 commented 1 year ago

Great! changing vromb_offset to 0x200000 for both games in romset.xml did the trick!

Toryalai1 commented 1 year ago

@kold669 Since it fixed the problem, you can close this issue