search

MiSTer-devel / NeoGeo_MiSTer

NeoGeo for MiSTer
GNU General Public License v2.0
145 stars 76 forks source link

ADPCM fix, ROMWAIT #175

Closed paulb-nl closed 1 year ago

paulb-nl commented 1 year ago

ADPCM fix for missing sample in Last Blade 2

Set ROMWAIT from xml. Fixes glitches in some screens in Ninja Commando. Needs update to Main

sorgelig commented 1 year ago

Is it something exists on real HW? Why cannot add wait signal permanently with fixed delay? There is another ROM format .neo where we can't add such flag (only if hardcode by game ID/name).

paulb-nl commented 1 year ago

The ROMWAIT and PWAIT signals come from the cartridge pcb so the cartridge decides if the wait cycles are needed.

I have only found 2 cartridges with ROMWAIT set: Blue's Journey and Ninja Commando. Here is an example: https://www.mvs-scans.com/images/3/38/Ninja_commando_set1_b1_front.jpg Look for "1 WAIT" jumper

All other games don't need these wait cycles.

For .neo format I have added it to NeoQuirks in Main so it works properly too.

sorgelig commented 1 year ago

i see.

sorgelig commented 1 year ago

Make a PR in Main then too.

mario-64 commented 1 year ago

The ROMWAIT and PWAIT signals come from the cartridge pcb so the cartridge decides if the wait cycles are needed.

I have only found 2 cartridges with ROMWAIT set: Blue's Journey and Ninja Commando. Here is an example: https://www.mvs-scans.com/images/3/38/Ninja_commando_set1_b1_front.jpg Look for "1 WAIT" jumper

All other games don't need these wait cycles.

For .neo format I have added it to NeoQuirks in Main so it works properly too.

I’m not familiar with NeoQuirks. Does this mean if using .neo format these fixes are baked into Main? No need to edit any files?

sorgelig commented 1 year ago

I’m not familiar with NeoQuirks. Does this mean if using .neo format these fixes are baked into Main? No need to edit any files?

right.