search

MiSTer-devel / PCXT_MiSTer

PCXT port for MiSTer by spark2k06.
GNU General Public License v3.0
15 stars 8 forks source link

Improvements from PCXT_Demistify ports by @gyurco and others by @somhi #79

Closed somhi closed 1 year ago

somhi commented 1 year ago

https://github.com/somhi/PCXT_DeMiSTify

somhi commented 1 year ago

to be checked: cur_rate = 28'd50000000; before was 30000000

in MiST ports it is only used by sound, not floppy or rtc

RTC commit by Gyurco has not been ported back https://github.com/somhi/PCXT_DeMiSTify/commit/2b657e02abf6ef2adba42cc859c3dc1bdb90047b

spark2k06 commented 1 year ago

There are some problems, the floppy drive doesn't work even returning the cur_rate value to 30000000, and the CMS sound has gotten worse. I reject the PR for the moment, but we will examine what can be gained from these changes.

spark2k06 commented 1 year ago

I have reopened the PR because I have seen that some things can work. However, I would like to get @kitune-san's opinion on this.

  1. This commit works, but I'd prefer kitune-san to assess it, as the operation is apparently the same: https://github.com/MiSTer-devel/PCXT_MiSTer/pull/79/commits/3032e51f1f36249d12cb15529cf9459227836b8b

  2. This commit creates some kind of conflict with the floppy drive, it stops working, let's see if kitune-san can shed some more light on the possible reason, because especially regarding the audio clocks, it seems more optimal to me: https://github.com/MiSTer-devel/PCXT_MiSTer/pull/79/commits/5fc54a6d3f2bdd73ae7692027424fb9eee095c9d. With these changes and cur_rate = 50000000, the pitch of game blaster seems to be the right one.

I attached binary resulting from these changes:

PCXT.zip

kitune-san commented 1 year ago 
1. This commit works, but I'd prefer kitune-san to assess it, as the operation is apparently the same: [3032e51](https://github.com/MiSTer-devel/PCXT_MiSTer/commit/3032e51f1f36249d12cb15529cf9459227836b8b)

If it works properly at the fastest cpu clock setting, you can apply that setting.

2. This commit creates some kind of conflict with the floppy drive, it stops working, let's see if kitune-san can shed some more light on the possible reason, because especially regarding the audio clocks, it seems more optimal to me: [5fc54a6](https://github.com/MiSTer-devel/PCXT_MiSTer/commit/5fc54a6d3f2bdd73ae7692027424fb9eee095c9d). With these changes and `cur_rate = 50000000`, the pitch of game blaster seems to be the right one.

When I added the FDD module. cur_rate was used only by the FDD module. (I didn't think other modules would use it.) The background of the change to 30000000 can be found below. https://misterfpga.org/viewtopic.php?p=61307#p61307 https://misterfpga.org/viewtopic.php?p=61477#p61477

kitune-san commented 1 year ago

If you want to set cur_rate to 50000000, I think the conflict can be resolved by changing the value of clock_rate or delay_adder in Floppy.v.

spark2k06 commented 1 year ago

If you want to set cur_rate to 50000000, I think the conflict can be resolved by changing the value of clock_rate or delay_adder in Floppy.v.

I understand, thank you.

However, with these changes... floppy doesn't work anymore even if I lower it back down to 30000000.

kitune-san commented 1 year ago

"clk_rate" and "clock_rate" are mixed up, so please unify either of them.

spark2k06 commented 1 year ago

Before:

https://soundcloud.com/aitor-gomez-7/cms-monkey-island-mister-pcxt

After:

https://soundcloud.com/aitor-gomez-7/cms-monkey-island-mister-pcxt-update