MiSTer-devel / PSX_MiSTer

PSX for MiSTer
GNU General Public License v2.0
204 stars 49 forks source link

Enhancements :: Texture Filtering :: Soul of the Samurai :: Texture Filtering introduces red lines in the title screen #253

Open YLFAndy opened 1 year ago

YLFAndy commented 1 year ago

Description: The title screen of Soul of the Samurai displays red horizontal lines when texture filtering is enabled.

Severity: Extremely minor/Enhancement

Frequency: 100%

Repro: Enable Video & Audio > Texture Filtering. Any setting will display the issue, however setting 'Filter 2D Detect' to Off makes the issue much more severe (see attached video capture). Launch Soul of the Samurai and proceed to the title screen by pressing 'Start' when the FMV begins to play (or wait).

Result: Horizontal red lines (and with some settings, a blue line) appear crossing the title screen.

Expected: No graphical corruption. TitleScreenBug.zip

RobertPeip commented 1 year ago

Original PS1 does not have texture filtering, so to even add this feature, i have to use some logic to identify which adjacent pixels of the texture could be used for filtering.

This can go wrong, e.g. when a game does some tricks with the textures and they are not "flat" in the x/y texture space.

I will probably not have time to look into this case any time soon to figure out which edge case it is here and if it can be solved at all, but if you want it can stay open until it's clarified.

YLFAndy commented 1 year ago

Totally. Just reported it as it might be data for any related bugs. Thanks for looking!