search

MiSTer-devel / SMS_MiSTer

Sega Master System for MiSTer
45 stars 43 forks source link

Request support for increased vertical resolution as used in Codemasters games #123

Closed MarkEire closed 1 year ago

MarkEire commented 2 years ago

Issue known to at least occur across Codemasters SMS games where games use a larger vertical resolution of 256x240, unlike typical games at 256x192 or 256x224.

Example in the title screen of Micro Machines (PAL only game, run with core set to PAL region). The lower text of the title screen should be fully present without being cut off.

Borders = On 04_PAL_MicroMachines_BorderYes

Further, the above image is the result over HDMI with "Borders = On". Perhaps related to issue: #120 Aspect ratio over HDMI behaves oddly. As of current SMS core, PAL aspect ratio is incorrect with borders off, always maintaining the NTSC aspect ratio. Micro Machines with "Borders = Off" behaves differently, stretching the aspect ratio towards (if not correct to) the desired PAL aspect ratio.

Borders = Off 05_PAL_MicroMachines_BorderNo

Thanks

birdybro commented 2 years ago

https://github.com/MiSTer-devel/SMS_MiSTer/commit/e77d367ebe22f8274c81ebc0c61a4f76e5e7ab7a

reference for later or if anyone else wants to work on it... mode3 is what codemasters should work on, but it apparently doesn't trigger it. a mapper probably needs to enable mode3 upon these codemasters games launching OR one of the other changes recently to video.vhd also caused a regression.

birdybro commented 2 years ago

This is solely because the vcrop is forcing 224p games to 216p on 1080p resolutions.

birdybro commented 1 year ago

This is resolved and will be in the next release.

MarkEire commented 1 year ago

Closed. Latest release confirmed to have added 224p and 240p support. Border appears yet to be implemented. Captured in new issue #163