search

MiSTer-devel / SMS_MiSTer

Sega Master System for MiSTer
45 stars 43 forks source link

Remove forced crop to support codemasters resolution in 1080p #133

Closed birdybro closed 2 years ago

birdybro commented 2 years ago

There are 256x224 resolution games, the forced cropping prevented the full resolution of the 4 256x224 mode games from being shown when the user was in 1920x1080p resolution. There are also apparently a few MSX conversion games that used this same resolution. This affected the following games:

Cosmic Spacehead The Excellent Dizzy Collection Fantastic Dizzy Micro Machines

https://www.smspower.org/Tags/Extra-Height

@Kitrinx came up with the idea to resolve the issue this way. The crop is probably not as beneficial on this system as many others, but there are a handful of 256x224 games as well that could probably benefit from it.

EDIT: This also solves this issue as a result --> https://github.com/MiSTer-devel/SMS_MiSTer/issues/120

birdybro commented 2 years ago

Actually closing this, I noticed a few problems with it (left column mask seemingly doing nothing now) and it should be done in a different way. I gotta think about this a little more.

EDIT: The different way I had in mind was over complicated, leaving it as a user option is better.

birdybro commented 2 years ago

Reopening this on account of advice from @paulb-nl

birdybro commented 2 years ago

So the issue with cut has to be fixed in video.vhd in another PR. Additionally, the border mode should not have an exception for smode_M1 (224p) that disables the vertical height just for that mode. Will try and fix that in a separate PR.