search

MiSTer-devel / SNES_MiSTer

SNES for MiSTer
GNU General Public License v3.0
199 stars 79 forks source link

MSU: Contra III - The Alien Wars: Music tracks appear to be off by one #336

Closed c0d3h4x0r closed 1 month ago

c0d3h4x0r commented 2 years ago

When the Konami logo appears at power-on, the level 1 background music plays. When you start playing level 1, the level 1 boss fight music plays. While fighting the level 1 boss, the short victory music plays over and over again. It seems the music tracks are off-by-1.

c0d3h4x0r commented 2 years ago

In fact, this off-by-one thing appears to be a global issue with all MSU-enhanced games I've tried.

Kitrinx commented 2 years ago

I can't reproduce this issue in contra III or any other game. Possibly you have a bad set of roms?

c0d3h4x0r commented 2 years ago

Over 50 ROMs all misconstructed in the exact same way? That's beyond unlikely.

Kitrinx commented 2 years ago

It is unlikely, but it's more likely than nobody else of many thousands of people mentioning this egregious issue. Check the indexing of the audio files and perhaps compare them to another set. Make sure you're using the latest unmodified main and SNES core from the mister repo. Perhaps have someone else test one of your msu1 roms to see if it's the data.

sorgelig commented 2 years ago

check if there is a specific map file which redefines index to file name. So romset may relay on mapping which MiSTer doesn't use.

c0d3h4x0r commented 2 years ago

My ROM set includes the following files (with MD5 hashes):

45c9332096d91d2fd9301472fb39a7df *Contra III - The Alien Wars (USA) (MSU1).bml
9b7a57ab51e3f62e1ad8a9ded2108591 *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-1.pcm
27d5fff40611a22116bd70509a161484 *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-10.pcm
4240e84613bf3d1181f022b9529f7574 *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-11.pcm
f6cb39ad56570e010e08e3d471db7afb *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-12.pcm
51221ffa340f4e612a4d6ad1a4dbec4b *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-13.pcm
5285b6f0e66cf777bc436822bbba6443 *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-14.pcm
c24a35ce1d269ba32a27a7b9263bf038 *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-15.pcm
4e53291e55370f3bcd6e67b05140c45b *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-2.pcm
abda9713e10e4c0e234fcf79bcf37a1e *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-3.pcm
cb15e9b71dcec9d2cceda74540040445 *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-4.pcm
6c79f929eed9e52fa76e784ce411e45e *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-5.pcm
d762f73ce323ce91b5ca119b6083e973 *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-6.pcm
53d3793d38f0b2576af93870b09c6190 *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-7.pcm
57bf67d61ae49b0b558c7e3dd9019ba5 *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-8.pcm
cf90cdbcca10bc0bba435079f8cb025a *Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-9.pcm
d41d8cd98f00b204e9800998ecf8427e *Contra_III_-_The_Alien_Wars_(USA)_(MSU1).msu
c7adf2dcd181dc4498f2ec1461aab5ed *Contra_III_-_The_Alien_Wars_(USA)_(MSU1).sfc

The .bml file contains the following:

board region=ntsc
  rom name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1).sfc size=0x100000
    map address=00-7d,80-ff:8000-ffff mask=0x8000
    map address=40-6f,c0-ef:0000-7fff mask=0x8000
  msu1
    map address=00-3f,80-bf:2000-2007
    rom name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1).msu
    track number=1 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-1.pcm
    track number=2 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-2.pcm
    track number=3 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-3.pcm
    track number=4 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-4.pcm
    track number=5 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-5.pcm
    track number=6 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-6.pcm
    track number=7 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-7.pcm
    track number=8 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-8.pcm
    track number=9 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-9.pcm
    track number=10 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-10.pcm
    track number=11 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-11.pcm
    track number=12 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-12.pcm
    track number=13 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-13.pcm
    track number=14 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-14.pcm
    track number=15 name=Contra_III_-_The_Alien_Wars_(USA)_(MSU1)-15.pcm

information
  title:  Contra III - The Alien Wars (USA) (MSU1)

If MiSTer is ignoring that .bml file and is instead relying upon filename lexicographic sort order, then it's going to play the tracks out of order, because (for example) 10 sorts before 2.

Kitrinx commented 2 years ago

You can review the correct naming conventions here: https://www.zeldix.net/t1607-msu1-getting-started-guide

c0d3h4x0r commented 2 years ago

There are several different naming conventions listed there. Which convention is correct for MiSTer?

Kitrinx commented 2 years ago

mister uses the same as sd2snes

sorgelig commented 2 years ago

If MiSTer is ignoring that .bml file and is instead relying upon filename lexicographic sort order, then it's going to play the tracks out of order, because (for example) 10 sorts before 2.

MiSTer doesn't use any sorting order. It will play the track number requested by core.

c0d3h4x0r commented 2 years ago

Confirmed that a new fileset renamed per the sd2snes convention works as expected. So this issue is really just a matter of insufficient/incomplete wiki documentation.

bikerspade commented 1 month ago

Confirmed that a new fileset renamed per the sd2snes convention works as expected. So this issue is really just a matter of insufficient/incomplete wiki documentation.

@c0d3h4x0r can you close the issue?